Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken encapsulation #32

Open
jfri3d opened this issue Oct 17, 2019 · 0 comments · May be fixed by #104
Open

Fix broken encapsulation #32

jfri3d opened this issue Oct 17, 2019 · 0 comments · May be fixed by #104
Labels
feature good first issue Good for newcomers hacktoberfest

Comments

@jfri3d
Copy link
Contributor

jfri3d commented Oct 17, 2019

What is the current behaviour?

Minimal bug found within JobService where it accesses pachyderm clients directly.

if not self.client.check_branch_exists(repo=pipeline_name, branch=pipeline_def["output_branch"]):
    self.client.pfs_client.create_branch(repo_name=pipeline_name, branch_name=pipeline_def["output_branch"])

What is the expected behaviour?

self.client.pfs_client is a violation!!!
@jfri3d jfri3d added the feature label Oct 17, 2019
@ms-shankar ms-shankar linked a pull request Jan 24, 2020 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

k-32: Abstracted pfs_client method in job_service KI-labs/kaos
1 participant
@jfri3d