Skip to content

Commit deb36a3

Browse files
authored
Fix dependency of TapDance on instantiated HoldTap (#1027)
1 parent 57f3ea2 commit deb36a3

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

kmk/modules/tapdance.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from kmk.keys import KC, Key, make_argumented_key
1+
from kmk.keys import Key, make_argumented_key
22
from kmk.modules.holdtap import ActivationType, HoldTap, HoldTapKey
33

44

@@ -15,7 +15,7 @@ def __init__(self, *keys, tap_time=None, **kwargs):
1515

1616
for key in keys:
1717
if not isinstance(key, HoldTapKey):
18-
ht_key = KC.HT(
18+
ht_key = HoldTapKey(
1919
tap=key,
2020
hold=key,
2121
prefer_hold=True,

tests/test_tapdance.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,17 @@
77
from tests.keyboard_test import KeyboardTest
88

99

10+
class TestTapDanceNoHT(unittest.TestCase):
11+
def test(self):
12+
KC.clear()
13+
14+
self.keyboard = KeyboardTest(
15+
[TapDance()],
16+
[[KC.TD(KC.N0, KC.N1)]],
17+
debug_enabled=False,
18+
)
19+
20+
1021
class TestTapDance(unittest.TestCase):
1122
def setUp(self):
1223
self.t_within = 2 * KeyboardTest.loop_delay_ms

0 commit comments

Comments
 (0)