Skip to content

Commit fc4e6b8

Browse files
committed
Fixup: Refactor hid.py
1 parent 80e23e2 commit fc4e6b8

File tree

3 files changed

+11
-8
lines changed

3 files changed

+11
-8
lines changed

kmk/hid.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ def get_action_map(self):
115115

116116
class NKROKeyboardReport(KeyboardReport):
117117
def __init__(self):
118-
super().__init__(size=_REPORT_SIZE_KEYBOARD_NKRO)
118+
super().__init__(_REPORT_SIZE_KEYBOARD_NKRO)
119119

120120
def add_key(self, key):
121121
self.buffer[(key.code >> 3) + 1] |= 1 << (key.code & 0x07)
@@ -142,8 +142,8 @@ def get_action_map(self):
142142

143143

144144
class PointingDeviceReport(Report):
145-
def __init__(self):
146-
super().__init__(_REPORT_SIZE_MOUSE)
145+
def __init__(self, size=_REPORT_SIZE_MOUSE):
146+
super().__init__(size)
147147

148148
def add_button(self, key):
149149
self.buffer[0] |= key.code
@@ -167,7 +167,7 @@ def get_action_map(self):
167167
return {Axis: self.move_axis, MouseKey: self.add_button}
168168

169169

170-
class HSPointingDeviceReport(Report):
170+
class HSPointingDeviceReport(PointingDeviceReport):
171171
def __init__(self):
172172
super().__init__(_REPORT_SIZE_MOUSE_HSCROLL)
173173

kmk/keys.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,10 @@ def __repr__(self) -> str:
3030
def move(self, keyboard: Keyboard, delta: int):
3131
self.delta += delta
3232
if self.delta:
33-
keyboard.axes.add(self)
33+
keyboard.keys_pressed.add(self)
3434
keyboard.hid_pending = True
3535
else:
36-
keyboard.axes.discard(self)
36+
keyboard.keys_pressed.discard(self)
3737

3838

3939
class AX:

kmk/kmk_keyboard.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -291,8 +291,11 @@ def _init_hid(self) -> None:
291291
debug('hid=', self._hid_helper)
292292

293293
def _deinit_hid(self) -> None:
294-
self._hid_helper.clear_all()
295-
self._hid_helper.send()
294+
try:
295+
self._hid_helper.create_report({})
296+
self._hid_helper.send()
297+
except Exception as e:
298+
debug_error(self, '_deinit_hid', e)
296299

297300
def _init_matrix(self) -> None:
298301
if self.matrix is None:

0 commit comments

Comments
 (0)