From 2d65564f8592d4a34bb92c6992c2eddfc16095ae Mon Sep 17 00:00:00 2001 From: KRM7 <70973547+KRM7@users.noreply.github.com> Date: Fri, 18 Aug 2023 18:41:30 +0200 Subject: [PATCH] temp --- .clang-tidy | 1 + .github/workflows/linux.yml | 10 +++------- CMakeLists.txt | 3 ++- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index a2abdb8f..23a628bd 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -29,6 +29,7 @@ -readability-container-data-pointer, -readability-suspicious-call-argument, -readability-implicit-bool-conversion, + -readability-uppercase-literal-suffix, -bugprone-easily-swappable-parameters, -bugprone-exception-escape, -cppcoreguidelines-special-member-functions, diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index c4c131e6..34beda95 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -11,20 +11,16 @@ jobs: build-type: [ Release, RelWithDebInfo ] compiler: [ { cxx: g++-11, pkgs: gcc-11 libtbb-dev }, - #{ cxx: g++-12, pkgs: gcc-12 libtbb-dev }, # disabled because of warnings in the std library + { cxx: g++-12, pkgs: gcc-12 libtbb-dev }, { cxx: clang++-14, pkgs: clang-14 libtbb-dev }, { cxx: clang++-15, pkgs: clang-15 libtbb-dev }, ] - lib-type: [ - { name: Static, cmake-flag: "OFF" }, - { name: Shared, cmake-flag: "ON" }, - ] defaults: run: working-directory: ${{ github.workspace }}/build - name: ${{ matrix.compiler.cxx }}, ${{ matrix.build-type }}, ${{ matrix.lib-type.name }} + name: ${{ matrix.compiler.cxx }}, ${{ matrix.build-type }} steps: - name: checkout-repo @@ -41,7 +37,7 @@ jobs: - name: setup-build env: CXX: ${{ matrix.compiler.cxx }} - run: cmake .. -DCMAKE_BUILD_TYPE=${{ matrix.build-type }} -DGAPP_LINK_TBB=ON -DBUILD_SHARED_LIBS=${{ matrix.lib-type.cmake-flag }} + run: cmake .. -DCMAKE_BUILD_TYPE=${{ matrix.build-type }} -DGAPP_LINK_TBB=ON -DBUILD_SHARED_LIBS=OFF - name: build run: cmake --build . --parallel diff --git a/CMakeLists.txt b/CMakeLists.txt index 3b8df400..46e625c8 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -101,7 +101,8 @@ else() # GNU style compiler interface # gcc specific options if(CMAKE_CXX_COMPILER_ID MATCHES "GNU") - set(GAPP_WARN_FLAGS "${GAPP_WARN_FLAGS} -Wlogical-op") + # https://gcc.gnu.org/bugzilla//show_bug.cgi?id=71434 with gcc 12 even though it's a system header + pragma diagnostic doesn't work + set(GAPP_WARN_FLAGS "${GAPP_WARN_FLAGS} -Wlogical-op -Wno-maybe-uninitialized") endif() # clang specific options if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")