From a5bc3b923bdc18cfcadf8d3cb5dc0c8e13ad69a5 Mon Sep 17 00:00:00 2001 From: KRM7 <70973547+KRM7@users.noreply.github.com> Date: Fri, 18 Aug 2023 18:41:30 +0200 Subject: [PATCH] temp --- .clang-tidy | 1 + .github/workflows/linux.yml | 10 +++------- CMakeLists.txt | 1 + src/utility/rng.hpp | 2 +- 4 files changed, 6 insertions(+), 8 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index a2abdb8f..23a628bd 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -29,6 +29,7 @@ -readability-container-data-pointer, -readability-suspicious-call-argument, -readability-implicit-bool-conversion, + -readability-uppercase-literal-suffix, -bugprone-easily-swappable-parameters, -bugprone-exception-escape, -cppcoreguidelines-special-member-functions, diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index c4c131e6..34beda95 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -11,20 +11,16 @@ jobs: build-type: [ Release, RelWithDebInfo ] compiler: [ { cxx: g++-11, pkgs: gcc-11 libtbb-dev }, - #{ cxx: g++-12, pkgs: gcc-12 libtbb-dev }, # disabled because of warnings in the std library + { cxx: g++-12, pkgs: gcc-12 libtbb-dev }, { cxx: clang++-14, pkgs: clang-14 libtbb-dev }, { cxx: clang++-15, pkgs: clang-15 libtbb-dev }, ] - lib-type: [ - { name: Static, cmake-flag: "OFF" }, - { name: Shared, cmake-flag: "ON" }, - ] defaults: run: working-directory: ${{ github.workspace }}/build - name: ${{ matrix.compiler.cxx }}, ${{ matrix.build-type }}, ${{ matrix.lib-type.name }} + name: ${{ matrix.compiler.cxx }}, ${{ matrix.build-type }} steps: - name: checkout-repo @@ -41,7 +37,7 @@ jobs: - name: setup-build env: CXX: ${{ matrix.compiler.cxx }} - run: cmake .. -DCMAKE_BUILD_TYPE=${{ matrix.build-type }} -DGAPP_LINK_TBB=ON -DBUILD_SHARED_LIBS=${{ matrix.lib-type.cmake-flag }} + run: cmake .. -DCMAKE_BUILD_TYPE=${{ matrix.build-type }} -DGAPP_LINK_TBB=ON -DBUILD_SHARED_LIBS=OFF - name: build run: cmake --build . --parallel diff --git a/CMakeLists.txt b/CMakeLists.txt index 3b8df400..113c96bc 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -87,6 +87,7 @@ else() # GNU style compiler interface endif() set(GAPP_OPT_FLAGS "-O3 -fno-math-errno -fno-trapping-math -freciprocal-math -fno-signed-zeros -fno-associative-math -fno-finite-math-only") + if(GAPP_USE_MARCH_NATIVE) set(GAPP_OPT_FLAGS "${GAPP_OPT_FLAGS} -march=native") endif() diff --git a/src/utility/rng.hpp b/src/utility/rng.hpp index ca66a9df..9392473b 100644 --- a/src/utility/rng.hpp +++ b/src/utility/rng.hpp @@ -226,7 +226,7 @@ namespace gapp::rng GAPP_ASSERT(n >= 0); GAPP_ASSERT(0.0 <= p && p <= 1.0); - return std::binomial_distribution{ n, p }(rng::prng); + return ( std::binomial_distribution{ n, p }(rng::prng) ); } template