Update small_vector.hpp

Author: KRM7

src/utility/small_vector.hpp

@@ -305,15 +305,15 @@ namespace gapp::detail
         constexpr small_vector_buffer() noexcept {};    // NOLINT(*default)
         constexpr ~small_vector_buffer() noexcept {};   // NOLINT(*default)
 
-        constexpr auto begin() noexcept { return static_cast<T*>(data_); }
-        constexpr auto begin() const noexcept { return static_cast<T*>(data_); }
+        constexpr auto begin() noexcept { return std::begin(data_); }
+        constexpr auto begin() const noexcept { return std::begin(data_); }
 
-        constexpr auto end() noexcept { return static_cast<T*>(data_) + Size; }
-        constexpr auto end() const noexcept { return static_cast<T*>(data_) + Size; }
+        constexpr auto end() noexcept { return std::end(data_); }
+        constexpr auto end() const noexcept { return std::end(data_); }
 
-        constexpr std::size_t size() const noexcept { return Size; }
+        constexpr std::size_t size() const noexcept { return std::size(data_); }
     private:
-        union { mutable T data_[Size]; };
+        union { char dummy_ = {}; T data_[Size]; }; // NOLINT(*arrays)
     };