Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Are credo and ex_doc needed as :prod dependencies? #9

Open
NobbZ opened this issue Sep 7, 2018 · 2 comments · May be fixed by #10
Open

Are credo and ex_doc needed as :prod dependencies? #9

NobbZ opened this issue Sep 7, 2018 · 2 comments · May be fixed by #10
Assignees
@indyone
Labels
bug

Comments

@NobbZ
Copy link

NobbZ commented Sep 7, 2018

As I am evaluating AMQP clients for a future project of mine, I discovered that you are specifiying credo and ex_doc as prod-dependencies. Are you really using them, or could they be changed to only: :dev?
@indyone indyone added the bug label Oct 24, 2018
@indyone indyone self-assigned this Oct 24, 2018
@indyone
Copy link
Member

indyone commented Oct 24, 2018

Yeap, you are probably right! Both credo & ex_doc are tools that are not needed on production.

NobbZ added a commit to NobbZ/exrabbitmq that referenced this issue Oct 24, 2018
@NobbZ
Make credo and exdoc dev-dependencies
a2184d4 
FIX Kaizen-Gaming#9
@NobbZ NobbZ linked a pull request Oct 24, 2018 that will close this issue
Open
@dennisxtria
Copy link
Contributor

Hello @NobbZ,

exrabbitmq has been updated recently, some of these changes being credo and ex_doc being set to only: :dev, so you should be ok now.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@indyone indyone

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make credo and exdoc dev-dependencies NobbZ/exrabbitmq
3 participants
@NobbZ @indyone @dennisxtria