Use `button` for token removal action instead of `a[href="#"]`

[paulrobertlloyd]

Currently, the token removal action uses a link with an empty fragment identifier:

<a href="#" class="item-remove" tabindex="-1">×</a>

As this action changes page state, rather than requests a new page, it should probably use a button instead, something like:

<button class="item-remove" tabindex="-1">×</button>

[KaneCohen]

Shouldn't affect the page state - there's a event.preventDefault() call that should stop usual link handling.
Any errors in the console?

[paulrobertlloyd]

Sorry, miscommunication on my part; was trying to explain the reason why you would use a button instead of a link. I think a button makes more sense for this action, not least as it will get announced with a more relevant description.

[KaneCohen]

Ah, got it.

I don't really actively support this library anymore. I've switched to using https://github.com/KaneCohen/select.

I'll see if I can update this and the other issue soon.