Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making a layout component for headers and footer #172

Open
ghost opened this issue Mar 14, 2023 · 6 comments · May be fixed by #174
Open

making a layout component for headers and footer #172

ghost opened this issue Mar 14, 2023 · 6 comments · May be fixed by #174
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@ghost
Copy link

ghost commented Mar 14, 2023

Describe the bug

hi! @Kanika637 😁
we could make the App.js more clean to see

Expected behaviour

Layout =({children})=>{
     <Header/>
         {children}
     <Footer/>
}
main=()=>{
  return <Layout >
  Cart component 
   </Layout>
}
main=()=>{
  return <Layout >
  Product component 
   </Layout>
}

Screenshots

No response

Additional context

No response

@ghost ghost added bug Something isn't working invalid This doesn't seem right labels Mar 14, 2023
@mud1tx
Copy link

mud1tx commented Mar 30, 2023

I can work on it if the issue is still active.

@mud1tx
Copy link

mud1tx commented Apr 7, 2023

I am trying to install the npm package but it is not running and showing some errors.
Screenshot (355)

I think that some packages are deprecated.

@mud1tx
Copy link

mud1tx commented Apr 7, 2023

I can fix the issue without running the project, just have to add Layout component?

@Kanika637
Copy link
Owner

I am trying to install the npm package but it is not running and showing some errors. Screenshot (355)

I think that some packages are deprecated.

Hey, try the command with -- force or --legacy-peer-deps as suggested. I think that would work.

@ThienBNguyen
Copy link

Hi Can I work in this issue?

@mominrazashahid mominrazashahid linked a pull request Aug 17, 2024 that will close this issue
4 tasks
@mominrazashahid
Copy link

@Kanika637 i open PR to fix this issue can you please review my PR i want to work on this project.
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants