Skip to content
This repository has been archived by the owner on Dec 23, 2024. It is now read-only.

refactor the vshard mode instructions, and settings to indicate to the pool what to use #12

Closed
KaymeKaydex opened this issue Apr 12, 2024 · 3 comments · Fixed by #111
Closed

refactor the vshard mode instructions, and settings to indicate to the pool what to use #12

KaymeKaydex opened this issue Apr 12, 2024 · 3 comments · Fixed by #111
Labels
enhancement New feature or request standard what is enshrined in the standard of the original vshard library

Comments

@KaymeKaydex
Copy link
Owner

now this can lead to such unpleasant situations

vshardrouter.CallOpts{
    VshardMode: vshardrouter.WriteMode,
    PoolMode:   pool.ANY,
    Timeout:    time.Second * 5,
},
@KaymeKaydex KaymeKaydex added enhancement New feature or request standard what is enshrined in the standard of the original vshard library labels Apr 12, 2024
@KaymeKaydex
Copy link
Owner Author

https://github.com/tarantool/vshard/blob/8d299bfecff8bc656056658350ad48c829f9ad3f/vshard/router/init.lua#L605

@KaymeKaydex
Copy link
Owner Author

I don’t see the point in communicating this standard in full, validation can be done, but I expect to implement all the conveniences in suguar interfaces

@KaymeKaydex
Copy link
Owner Author

#10

@nurzhan-saktaganov nurzhan-saktaganov mentioned this issue Dec 12, 2024
Closed
@nurzhan-saktaganov nurzhan-saktaganov linked a pull request Dec 12, 2024 that will close this issue
resolve issue #110 #111
Merged
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request standard what is enshrined in the standard of the original vshard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resolve issue #110 KaymeKaydex/go-vshard-router
1 participant
@KaymeKaydex