Merge branch 'features/Code_cleanup'

Author: KeRNeLith

src/Here.Tests/HereTestsBase.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections.Generic;
 
 namespace Here.Tests
 {
@@ -19,6 +20,21 @@ public PersonNotEquatable(string name)
             }
         }
 
+        protected class PersonComparable : IComparable<PersonComparable>
+        {
+            public string _name;
+
+            public PersonComparable(string name)
+            {
+                _name = name;
+            }
+
+            public int CompareTo(PersonComparable other)
+            {
+                return Comparer<string>.Default.Compare(_name, other._name);
+            }
+        }
+
         protected class Person
         {
             private readonly string _name;

src/Here.Tests/Result/ResultTests.cs

@@ -1518,6 +1518,18 @@ public void ValueResultCompare()
             Assert.AreEqual(0, resultFail3.CompareTo(resultFail1));
             Assert.AreEqual(0, resultFail3.CompareTo((object)resultFail1));
 
+            // Comparable reference type
+            var person1 = new PersonComparable("Jo");
+            var person2 = new PersonComparable("John");
+            var resultOk4 = Result.Ok(person1);
+            var resultOk5 = Result.Ok(person1);
+            var resultOk6 = Result.Ok(person2);
+            Assert.AreEqual(0, resultOk4.CompareTo(resultOk5));
+            Assert.AreEqual(0, resultOk5.CompareTo(resultOk4));
+
+            Assert.AreEqual(-1, resultOk4.CompareTo(resultOk6));
+            Assert.AreEqual(1, resultOk6.CompareTo(resultOk4));
+
             // Mixed
             Assert.AreEqual(1, resultOk1.CompareTo(null));      // Null is always the minimal value
             Assert.AreEqual(1, resultWarn1.CompareTo(null));    // Null is always the minimal value
@@ -1705,6 +1717,18 @@ public void CustomValueResultCompare()
             Assert.AreEqual(0, resultFail3.CompareTo(resultFail1));
             Assert.AreEqual(0, resultFail3.CompareTo((object)resultFail1));
 
+            // Comparable reference type
+            var person1 = new PersonComparable("Jo");
+            var person2 = new PersonComparable("John");
+            var resultOk4 = Result.Ok<PersonComparable, CustomErrorTest>(person1);
+            var resultOk5 = Result.Ok<PersonComparable, CustomErrorTest>(person1);
+            var resultOk6 = Result.Ok<PersonComparable, CustomErrorTest>(person2);
+            Assert.AreEqual(0, resultOk4.CompareTo(resultOk5));
+            Assert.AreEqual(0, resultOk5.CompareTo(resultOk4));
+
+            Assert.AreEqual(-1, resultOk4.CompareTo(resultOk6));
+            Assert.AreEqual(1, resultOk6.CompareTo(resultOk4));
+
             // Mixed
             Assert.AreEqual(1, resultOk1.CompareTo(null));      // Null is always the minimal value
             Assert.AreEqual(1, resultWarn1.CompareTo(null));    // Null is always the minimal value