Merge pull request #220 from KenEucker/develop

fix(sanity): fixes issues with retrieving the player data from sanity

Author: KenEucker

examples/node/index.js

@@ -128,6 +128,14 @@ const getAllGamesAsync = async (pre, client, out = false, opts = {}) => {
   return testGameData
 }
 
+const get1PlayerAsync = async (pre, client, out = false, opts = {}) => {
+  opts.limit = opts.limit ? opts.limit : 10
+  const testPlayerData = await client.getPlayer('player-test', opts).catch(console.error)
+  log(`${pre} :: success fully retrieved player data`, testPlayerData, out)
+
+  return testPlayerData
+}
+
 const get10PlayersAsync = async (pre, client, out = false, opts = {}) => {
   opts.limit = opts.limit ? opts.limit : 10
   const testPlayerData = await client.getPlayers(undefined, opts).catch(console.error)
@@ -199,6 +207,7 @@ const runTests = async (out = false) => {
     await getGameAsync("Sanity", bikeTagSanityInstance, out)
     // await getAllGamesAsync("Sanity", bikeTagSanityInstance, out)
     await get10PlayersAsync("Sanity", bikeTagSanityInstance, out)
+    await get1PlayerAsync("Sanity", bikeTagSanityInstance, out)
     // await get10AmbassadorsAsync("Sanity", bikeTagSanityInstance, out)
     // await get10SettingsAsync("Sanity", bikeTagSanityInstance, out)
     // await get10AchievementsAsync("Sanity", bikeTagSanityInstance, out)

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "biketag",
-  "version": "3.2.2",
+  "version": "3.2.3",
   "description": "The Javascript client API for BikeTag Games",
   "main": "./biketag.node.js",
   "browser": "./biketag.js",

package.json

@@ -1081,7 +1081,7 @@ export class BikeTagClient extends EventEmitter {
     /// Else, use the get all and filter method
     return this.getPlayers(
       this.getInitialPayload(
-        payload,
+        options,
         undefined,
         'getPlayers'
       ) as getPlayersPayload,
@@ -1214,7 +1214,7 @@ export class BikeTagClient extends EventEmitter {
     /// Else, use the get all and filter method
     return this.getAmbassadors(
       this.getInitialPayload(
-        payload,
+        options,
         undefined,
         'getAmbassadors'
       ) as getAmbassadorsPayload,
@@ -1311,7 +1311,7 @@ export class BikeTagClient extends EventEmitter {
     /// Else, use the get all and filter method
     return this.getSettings(
       this.getInitialPayload(
-        payload,
+        options,
         undefined,
         'getSettings'
       ) as unknown as getSettingsPayload,
@@ -1401,7 +1401,7 @@ export class BikeTagClient extends EventEmitter {
     /// Else, use the get all and filter method
     return this.getAchievements(
       this.getInitialPayload(
-        payload,
+        options,
         undefined,
         'getAchievements'
       ) as unknown as getAchievementsPayload,

src/client.ts

@@ -75,10 +75,11 @@ export type getPlayersPayload = {
   hash?: string
   limit?: number
   account?: string
-  name?: string
+  names?: string[]
 } & CommonPayloadData
 
 export type getPlayerPayload = {
+  name?: string
   fields?: string[]
   slug?: string
   hash?: string
@@ -117,6 +118,7 @@ export type getAmbassadorsPayload = {
   sort?: SortOptions
   slugs?: string[]
 } & CommonPayloadData
+
 export type getAmbassadorPayload = {
   fields?: string[]
   slug?: string

src/common/payloads.ts

@@ -23,7 +23,7 @@ export async function getPlayers(
     DataTypes[DataTypes.player],
     /// NOT PASSING IN THE GAME because we are not yet assigning players to games
     undefined, // payload.game,
-    payload.name,
+    payload.names?.length === 1 ? payload.names[0] : undefined,
     payload.slugs,
     undefined,
     fields