Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace HtmlAgilityPack with AngleSharp #24

Open
OndrejVrsan opened this issue Feb 26, 2018 · 2 comments
Open

Replace HtmlAgilityPack with AngleSharp #24

OndrejVrsan opened this issue Feb 26, 2018 · 2 comments
Assignees
@rsuzumura
Labels
groomed The issue has been groomed and should be in a good shape. hacktoberfest help wanted refactoring up-for-grabs

Comments

@OndrejVrsan
Copy link
Contributor

OndrejVrsan commented Feb 26, 2018 •
edited by petrsvihlik
Loading

Problem definition

While Kentico 11 CMS App has a dependency on AngleSharp, Kentico AMP uses HtmlAgilityPack, which provides a similar functionality. It's redundant to have both.

Suggested solution

Get rid of the HtmlAgilityPack dependency and replace it with AngleSharp.
Note: AngleSharp does not support XPaths, the code needs to be rewritten to LINQ for AngleSharp.
@petrsvihlik petrsvihlik changed the title Replace HtmlAgilityPack to AngleSharp Replace HtmlAgilityPack with AngleSharp Sep 11, 2018
@petrsvihlik petrsvihlik added enhancement hacktoberfest groomed The issue has been groomed and should be in a good shape. refactoring and removed enhancement labels Sep 11, 2018
@rsuzumura
Copy link

Hi, I want to help on that refactoring, can you assign this issue to me? Thanks!

@petrsvihlik
Copy link
Contributor

@rsuzumura absolutely, go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rsuzumura rsuzumura

Labels
groomed The issue has been groomed and should be in a good shape. hacktoberfest help wanted refactoring up-for-grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rsuzumura @petrsvihlik @OndrejVrsan