Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest bug fixes for Kentico 11 version of AMP module not included in K11 NuGet release #38

Open
mkayan-wakefly opened this issue Oct 28, 2019 · 2 comments

Comments

@mkayan-wakefly
Copy link

Brief bug description

In a Kentico 11.0.49 site, I installed the K11 release of the Kentico.AcceleratedMobilePages module via NuGet. The generated AMP tag includes the specified AMP domain, and all the URL friendly extensions for the site. (http://amp.local.wfdev.net;;.aspx;.html;.xml;.txt)

I think this may have been fixed in #31, but that fix doesn't seem to be pulled down in the Kentico 11 version of the module.

Repro steps

  1. Open a K11 site in Visual Studio
  2. Right click on the solution and "manage NuGet Packages for Solution"
  3. Select the "Browse" tag, and get "Kentico.AcceleratedMobilePages"
  4. Install version 11.0 of the AMP module
  5. Go into the admin section of the site, Settings > System > Output Filter. Enable AMP, and specify an AMP domain alias
  6. In the Pages app, select a page (e.g. "/thewire"), go to the "AMP filter" properties tab. Select "Enable AMP for this page"
  7. View source for domain.com/thewire. There is an amphtml tag with an href of amp.domain.com;;.aspx;.html;.xml;.txt

Expected behavior

domain.com/thewire should have an amphtml tag with an href of amp.domain.com/thewire

Test environment

  • Platform/OS: Windows 10, Kentico 11.0.49
  • Browser: Firefox
  • Version 11.0.0

Additional context

I'm hoping the Kentico 11 release of this module can be updated to include the bug fixes made before it was ported to Kentico 12.

@petrsvihlik
Copy link
Contributor

@Kentico/platform-team could you guys please take a look at it?

@ivann14
Copy link

ivann14 commented Nov 5, 2019

Regarding the support for version 11 - we only provide support for the last released version of Kentico, which is currently version 12. Moreover, you can create AMP module copying this repository by yourself. I forked this repository and made minor changes so that it can be run with version 11 here -> https://github.com/ivann14/kentico-amp but please do not consider this as an official Kentico repository or channel it is only supposed to give you a hint what to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants