Skip to content

Commit 7c2e28d

Browse files
xsustekseangwright
andauthored
Apply suggestions from code review
Co-authored-by: Sean G. Wright <sean@seangwright.me>
1 parent f2234cd commit 7c2e28d

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ dotnet add package Kentico.Xperience.TagManager
3535

3636
## Quick Start
3737
1. Include `Kentico.Xperience.TagManager` project in the solution.
38-
1. Add to live site project as project dependency.
38+
1. Add to Xperience by Kentico application as project dependency.
3939
1. Register required services into DI container.
4040

4141
```csharp

src/Kentico.Xperience.TagManager/Admin/UIPages/CodeSnippetModelCreate.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ protected override async Task<ICommandResponse> SubmitInternal(
8787

8888
}
8989

90-
private ChannelCodeSnippetInfo CreateCodeSnippetInfo(CodeSnippetEditModel model)
90+
private void CreateCodeSnippetInfo(CodeSnippetEditModel model)
9191
{
9292
var infoObject = new ChannelCodeSnippetInfo
9393
{

src/Kentico.Xperience.TagManager/Admin/UIPages/Models/CodeSnippetEditModel.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ internal class CodeSnippetEditModel
88
{
99
[RequiredValidationRule]
1010
[ObjectIdSelectorComponent(objectType: "cms.channel", Label = "Channel", Order = 1, WhereConditionProviderType = typeof(ChannelSelectorWhereConditionProvider))]
11-
public IEnumerable<int> ChannelID { get; set; } = [];
11+
public IEnumerable<int> ChannelIDs { get; set; } = [];
1212

1313
[RequiredValidationRule]
1414
[DropDownComponent(Label = "Code snippet type", Order = 2, DataProviderType = typeof(CodeSnippetTypesDropdownOptionsProvider))]
@@ -27,5 +27,5 @@ internal class CodeSnippetEditModel
2727
public string? GTMID { get; set; }
2828

2929
[ObjectIdSelectorComponent(objectType: "cms.consent", Label = "Consent", Order = 5, Placeholder = "{$customchannelsettings.codesnippets.noconsentneeded$}")]
30-
public IEnumerable<int> ConsentID { get; set; } = [];
30+
public IEnumerable<int> ConsentIDs { get; set; } = [];
3131
}

src/Kentico.Xperience.TagManager/Modules/CustomChannelSettingsModuleInstaller.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ private static void InstallChannelCodeSnippetClass(ResourceInfo resourceInfo)
5555

5656
channelCodeSnippetClass.ClassName = ChannelCodeSnippetInfo.OBJECT_TYPE;
5757
channelCodeSnippetClass.ClassTableName = ChannelCodeSnippetInfo.OBJECT_TYPE.Replace(".", "_");
58-
channelCodeSnippetClass.ClassDisplayName = "ChannelCodeSnippet";
58+
channelCodeSnippetClass.ClassDisplayName = "Channel Code Snippet";
5959
channelCodeSnippetClass.ClassResourceID = resourceInfo.ResourceID;
6060
channelCodeSnippetClass.ClassType = ClassType.OTHER;
6161
var formInfo = FormHelper.GetBasicFormDefinition(nameof(ChannelCodeSnippetInfo.ChannelCodeSnippetID));

0 commit comments

Comments
 (0)