Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create configuration option for API base path #3

Open
m8rmclaren opened this issue Aug 23, 2023 · 0 comments
Open

Create configuration option for API base path #3

m8rmclaren opened this issue Aug 23, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@m8rmclaren
Copy link
Contributor

Currently, the base path of the Keyfactor API is statically defined in the execution function of each endpoint:

var (
localVarHTTPMethod   = http.MethodPost
localVarPostBody     interface{}
formFiles            []formFile
localVarReturnValue  *KeyfactorApiModelsAlertsIssuedIssuedAlertDefinitionResponse
)

localBasePath := "/KeyfactorAPI"

localVarPath := localBasePath + "/Alerts/Issued"

This should be a configuration field of the keyfactor.Configuration struct with a default setting. This way, Command configurations with differing API base paths can be supported by this SDK.
@m8rmclaren m8rmclaren added the enhancement New feature or request label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@m8rmclaren