Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Names #8

Open
KhoonSun47 opened this issue Apr 19, 2024 · 1 comment
Open

Duplicate Names #8

KhoonSun47 opened this issue Apr 19, 2024 · 1 comment

Comments

@KhoonSun47
Copy link
Owner

KhoonSun47 commented Apr 19, 2024

Steps to reproduce:

  • Currently, adding double spaces into the names is allowed, which should not be the case.
  • They are unlikely to be two different person, just because there is an additional space in between the name. This could also be a result of user making a typo.

Actual Output:
Step 1: Adding a person named called "John Doe"
image.png

Step 2: Adding a person named called "John Doe"
image.png

Expected Output:

  • The system should give an error message that the same name has already been added to the data.

Suggestion: I believe that should ignore the whitespace in between the names.

@nus-se-script
Copy link

nus-se-script commented Apr 22, 2024

Team's Response

Thanks for raising this issue, indeed it can be improved further in future enhancements.

Items for the Tester to Verify

❓ Issue response

Team chose [response.NotInScope]

  • I disagree

Reason for disagreement: I disagree with the decision that this response is "response.NotInScope," and I believe that it should be "response.Accepted" instead. 


This feature could be enhanced significantly from the user's perspective with minimal additional effort. 


The website already acknowledges the bugs related to duplicate detection, emphasising that exact matches are insufficient and suggesting that warnings for near matches would improve user decision-making.

Feature flaws can be claimed as NotInScope, if they qualify as per rules explained.png


❓ Issue type

Team chose [type.FeatureFlaw]
Originally [type.FunctionalityBug]

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants