Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Java 21 #535

Open
tim-we opened this issue Jan 19, 2024 · 2 comments · May be fixed by #551
Open

Switch to Java 21 #535

tim-we opened this issue Jan 19, 2024 · 2 comments · May be fixed by #551
Labels
github_actions Pull requests that update GitHub Actions code java Pull requests that update Java code Server

Comments

@tim-we
Copy link
Member

tim-we commented Jan 19, 2024 •
edited
Loading

We should switch to the current LTS version of Java, which at the time of writing is Java 21.

https://mydeveloperplanet.com/2023/11/01/whats-new-between-java-17-and-java-21/
@tim-we tim-we added Server java Pull requests that update Java code github_actions Pull requests that update GitHub Actions code labels Jan 19, 2024
tim-we added a commit that referenced this issue Feb 11, 2024
@tim-we
Switch to Java 21 (#535)
2abaefe
@tim-we tim-we self-assigned this Feb 11, 2024
@tim-we tim-we linked a pull request Feb 11, 2024 that will close this issue
Draft
@tim-we tim-we linked a pull request Feb 11, 2024 that will close this issue
Switch to Java 21 #551
Draft
@tim-we tim-we removed their assignment Feb 11, 2024
@tim-we
Copy link
Member Author

tim-we commented Feb 11, 2024

Seems like we have to wait for new Mockito release that is compatible with Java 21. Currently the test are failing because Mockito fails to mock classes.

@tim-we
Copy link
Member Author

tim-we commented Mar 3, 2024

Try to change pom.xml from

<maven.compiler.source>17</maven.compiler.source>
<maven.compiler.target>17</maven.compiler.target>

to

<maven.compiler.release>17</maven.compiler.release>

Make sure this works in the CI pipeline, there were some issues with the maven compiler plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code java Pull requests that update Java code Server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to Java 21 KielerGames/ringofsnakes
1 participant
@tim-we