Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Simple Review] Old review comment doesn't apply to current review? #1918

Open
k88hudson opened this issue Jun 14, 2021 · 1 comment
Open

[Simple Review] Old review comment doesn't apply to current review? #1918

k88hudson opened this issue Jun 14, 2021 · 1 comment
Labels
scope:nimbus stale For marking issues as stale. Labeled issues will be closed soon if label is not removed.

Comments

@k88hudson
Copy link
Contributor

I noticed this while testing in staging:

image

it looks like the review request comment that's being displayed doesn't apply to the current review request, maybe it's because there was no comment associated with the current so it was never updated?
@leplatrem
Copy link
Contributor

The code on the admin looks sound. A comment field is passed on each action.

This could be Experimenter not specifying the field.

Nonetheless I think this should be on the server side (default to "" if comment is not specified).

@leplatrem leplatrem mentioned this issue Jun 15, 2021
Merged
@alexcottner alexcottner added the stale For marking issues as stale. Labeled issues will be closed soon if label is not removed. label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope:nimbus stale For marking issues as stale. Labeled issues will be closed soon if label is not removed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@leplatrem @k88hudson @alexcottner