Merge pull request #613 from agirault/fix-setMatrix

jourdain · web-flow · commit 4edea925a74a · 2018-02-26T19:51:55.000-07:00
fix(MatrixBuilder): allow using typed array in setMatrix
diff --git a/Sources/Common/Core/MatrixBuilder/index.js b/Sources/Common/Core/MatrixBuilder/index.js
@@ -110,7 +110,7 @@ class Transform {
   }
 
   setMatrix(mat4x4) {
-    if (Array.isArray(mat4x4) && mat4x4.length === 16) {
+    if (!!mat4x4 && mat4x4.length === 16) {
       this.matrix[0] = mat4x4[0];
       this.matrix[1] = mat4x4[1];
       this.matrix[2] = mat4x4[2];

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ class Transform {`
`110`	`110`	`}`
`111`	`111`
`112`	`112`	`setMatrix(mat4x4) {`
`113`		`- if (Array.isArray(mat4x4) && mat4x4.length === 16) {`
	`113`	`+ if (!!mat4x4 && mat4x4.length === 16) {`
`114`	`114`	`this.matrix[0] = mat4x4[0];`
`115`	`115`	`this.matrix[1] = mat4x4[1];`
`116`	`116`	`this.matrix[2] = mat4x4[2];`