Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vtkImageData returns incorrect bounds #820

Open
luciemac opened this issue Aug 2, 2018 · 1 comment
Open

vtkImageData returns incorrect bounds #820

luciemac opened this issue Aug 2, 2018 · 1 comment
Labels
type: feature request 💡 Desired capabilities / enhancements

Comments

@luciemac
Copy link
Contributor

luciemac commented Aug 2, 2018

Origin and spacing can be stored in 64bits when bounds are stored in a Float32Array. This leaks to computational errors between vtk.js and user applications.
What should be done?
Please see toji/gl-matrix#192.

Should we add glMatrix.ARRAY_TYPE = Float64Array or should we modify vtkImageData to define matrices (such as indexToWorld) as a Float64Array instead of using mat4.create()?
@jourdain
Copy link
Collaborator

jourdain commented Aug 2, 2018

I would suggest vtk,js to create its own Float64Array and maybe keep a ref internally if that temporary array get created/deleted a lot...

Somewhat similar to this

@floryst floryst added the type: feature request 💡 Desired capabilities / enhancements label Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature request 💡 Desired capabilities / enhancements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jourdain @floryst @luciemac