Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all stacktrace entries in the list #27

Closed
fredrikekre opened this issue Aug 23, 2024 · 4 comments
Closed

Include all stacktrace entries in the list #27

fredrikekre opened this issue Aug 23, 2024 · 4 comments

Comments

@fredrikekre
Copy link
Contributor

Currently frames are filtered out here

if vim.api.nvim_buf_get_name(bufnbr) ~= stackrow[1] then
goto continue
end

but I think it would be good to include all entries in the trace so you can easily jump to any frame even if it doesn't belong to buffer that is attached to the smuggler.

@Klafyvel
Copy link
Owner

Yes, I think it had something to do with the ability to display diagnostics in a given buffer (you need a buffer number :help vim.diagnostic.set()). But probably this can be handled in the display part!

@fredrikekre
Copy link
Contributor Author

Yea I saw that too. Perhaps they don't have to be linked? e.g. we can build a quickfix list with all entries and a diagnostic list separately?

@Klafyvel
Copy link
Owner

Yes, that's the way I'm taking in #15. I store the server's responses with the configuration of the buffer and display either the diagnostic or the quickfix list on demand.

Klafyvel added a commit that referenced this issue Oct 5, 2024
Fix #12 and #27.

BREAKING CHANGE: New protocol version is used.
BREAKING CHANGE: Using the quickfix list instead of the loclist. Commands were renamed.
@Klafyvel
Copy link
Owner

Klafyvel commented Oct 5, 2024

The quickfix list is now completely separated from the diagnostics, and thus can take you to wherever errors occured!

@Klafyvel Klafyvel closed this as completed Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants