Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display evaluation results #15

Merged
merged 19 commits into from
Sep 10, 2024
Merged

Display evaluation results #15

merged 19 commits into from
Sep 10, 2024

Conversation

Klafyvel
Copy link
Owner

@Klafyvel Klafyvel commented Aug 7, 2024 •
edited
Loading

Goes along Klafyvel/REPLSmuggler.jl#35

TODO:

  • Display evaluation result as text
  • Add configuration options for result display (linewidth etc...)
  • Add toggle command for result display
  • Rework errors display (fixing Make the loclist smarter #12) : Toggle command that works better (keep diagnostics in config and populate diagnostics/loclist as requested when toggling)
  • Display images if image.nvim is present
  • Add configuration options for images (sizes for example)

@Klafyvel
Copy link
Owner Author

Klafyvel commented Aug 7, 2024

First rough display of results:

image

@Klafyvel Klafyvel marked this pull request as draft August 7, 2024 22:08
@Klafyvel Klafyvel changed the title WIP: Display evaluation results Display evaluation results Aug 7, 2024
@Klafyvel Klafyvel mentioned this pull request Aug 7, 2024
Merged
4 tasks
@Klafyvel
Copy link
Owner Author

The evaluated chunks are now highlighted using NeoVim's extmark.

asciicast

@Klafyvel
Copy link
Owner Author

Still TODO before doing the images: removing old results and chunks when a chunk is made invalid because the user re-ran code within a pre-existing chunk.

This was referenced Aug 21, 2024
Merged
Closed
Klafyvel added 13 commits August 25, 2024 16:05
@Klafyvel
feat(results): Display evaluation results.
7f85b72
@Klafyvel
refactor(protocol): Refactor the protocol client to use async feature…
cca15eb 
…s cleanly.
@Klafyvel
refactor(ui): Created a dedicated module for managing the ui.
cc4e6dd 
BREAKING CHANGE: THe syntax for the configuration of mappings changed.
See the documentation `:help smuggler-configuration` for details.
@Klafyvel
feat(ui): Highlight evaluated chunks in buffers.
f02c41d 
The chunks are highlighted by a colored bar on the left column. See
documentation to configure the highlight group used. Refactored the code
to separate UI from the other features.
@Klafyvel
refactor(diagnostics): Moved diagnostics display to the new system.
df22aaf
@Klafyvel
refactor(protocol): Moved buffer handling out of protocol.
8e34332
@Klafyvel
chore(buffers): Cleanup old buffer fields.
bd458cd
@Klafyvel
feat(ui): Added configuration options for display of results.
a869907
@Klafyvel
refactor(buffers): Use nvim api to detect invalidated code chunks.
0741e5a
@Klafyvel
fix(buffers): Detect chunks invalidation consistently.
1cd54ca
@Klafyvel
feat(buffers): Delete invalidated chunks and results when evaluating …
f91987d 
…a new chunk.
@Klafyvel
fix(reslime): set column position correctly for smuggling visual lines.
37b7d42
@Klafyvel
feat(images): Display image results if image.nvim is present!
9e49b38
@Klafyvel Klafyvel force-pushed the feat-display-evaluation-results branch from 70101ec to 9e49b38 Compare August 25, 2024 14:07
@Klafyvel
Copy link
Owner Author

Images are now displayed!

image

@Klafyvel
Copy link
Owner Author

Missing configuration options:

  • IOContext keywords for text results
  • Sizes options for images
  • More options for displaying results:
    • Display by block: display results attached to the chunk they belong to rather than the line that produced it when evaluating the chunk
    • Pluto-like display: display results above the code that produced it rather than below

@Klafyvel
Copy link
Owner Author

Klafyvel commented Aug 31, 2024 •
edited
Loading

Removed the capture function from the todo-list. This can be implemented later. Same goes for the display options.

@Klafyvel Klafyvel force-pushed the feat-display-evaluation-results branch from 63824c6 to c07fe8a Compare August 31, 2024 15:56
@Klafyvel
fix(client): Smarter client to handle partial or overlapping server r…
cef2b4e 
…esponses.

The previous implementation was behaving badly when sending huge code
chunks (e.g. a whole file with heacy treatments).
This was referenced Sep 9, 2024
Merged
Open
Open
@Klafyvel Klafyvel marked this pull request as ready for review September 10, 2024 15:13
@Klafyvel Klafyvel merged commit c47e3a2 into main Sep 10, 2024
1 check passed
@Klafyvel Klafyvel deleted the feat-display-evaluation-results branch September 10, 2024 15:14
This was referenced Sep 11, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Klafyvel