Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish circum-icon-core on npm, export { iconList } #21

Open
einar-hjortdal opened this issue Nov 20, 2023 · 1 comment
Open

Publish circum-icon-core on npm, export { iconList } #21

einar-hjortdal opened this issue Nov 20, 2023 · 1 comment

Comments

@einar-hjortdal
Copy link

einar-hjortdal commented Nov 20, 2023

I want to use these icons in Inferno.
I need to be able to import iconList in my Inferno wrapper.
To do so, I need a package that exports the iconList const. Right now, the only solution is to clone your repository, manually copy the iconList.js file in my source directory.
It would be better if you could publish a package that exports { iconList } instead. This is to help third parties to include your package as a whole (including a copy of the license, links to source etc) in their distribution.

I would go one step further and refactor your packages to have circum-icon-core as dependency and import { iconList } from circum-icon-core

Temporarily, the manual copy/pasting approach is used for this package.

@Klarr-Agency
Copy link
Owner

Hi @Coachonko,

Sorry for the delay.
There is a lot of improvement that could be done. I know that it is not ideal but you can probably access iconlist this way: import { icons } from '@klarr-agency/circum-icons-svelte/src/iconList'; Anyway, I agree with you it would be best to use circum-icon-core as a dependency for the other packages.

Feel free to open a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants