Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi @Klerith , #35

Open
thorito opened this issue Mar 1, 2024 · 1 comment
Open

Hi @Klerith , #35

thorito opened this issue Mar 1, 2024 · 1 comment

Comments

@thorito
Copy link
Contributor

thorito commented Mar 1, 2024

          Hi @Klerith ,

I think there was some error when merging with the latest version. The 'to' and 'from' fields do not appear.

I attach the original changes to the PR. Diff

Greetings

Originally posted by @thorito in #33 (comment)

@Klerith
Copy link
Owner

Klerith commented Mar 6, 2024

Hello @thorito

I made a mistake, indeed. Your change came while I was doing a big refactor, and I also have two separate projects, one for testing and the package itself (which is this one), now I just have this one.

If it isn't too much to ask, can you create a new PR based on the latest changes?

Please don't call the curve in animation a curve; just call it a curve. I can't call it curve in without introducing breaking changes.

I will merge it and publish it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants