Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-filtering interested messages in logger module #24

Open
KockaAdmiralac opened this issue Mar 3, 2019 · 0 comments
Open

Pre-filtering interested messages in logger module #24

KockaAdmiralac opened this issue Mar 3, 2019 · 0 comments
Assignees
Labels
architectural Purely architectural issues with no user-facing impact.

Comments

@KockaAdmiralac
Copy link
Owner

Description

The logger module is telling the client it's interested in messages that are going to be filtered out by the filters afterwards, causing KockaLogger to make unneeded API/Redis requests.

Reproduction steps

Steps to reproduce the behavior:

  1. Set up a Discussions-only logger for a wiki.
  2. Set up an HTTP request logger.
  3. Create a page on the wiki.
  4. Check whether an API request was made to fetch the page title.

Expected behavior

There should be no interest shown in messages that aren't going to be shown.

Notes

Doing filtering inside interested() may create different issues due to titles not being the page's actual titles before the title information is checked. A different configuration option may need to be set up for this.

@KockaAdmiralac KockaAdmiralac added the architectural Purely architectural issues with no user-facing impact. label Mar 3, 2019
@KockaAdmiralac KockaAdmiralac self-assigned this Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architectural Purely architectural issues with no user-facing impact.
Projects
None yet
Development

No branches or pull requests

1 participant