Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: ImageMaid vs old repo Plex-image-cleanup #2161

Open
arsenicks opened this issue Jul 15, 2024 · 1 comment
Open

[Docs]: ImageMaid vs old repo Plex-image-cleanup #2161

arsenicks opened this issue Jul 15, 2024 · 1 comment
Assignees
Labels
documentation Issue is related to documentation status:not-yet-viewed I haven't reviewed the Feature or Bug yet

Comments

@arsenicks
Copy link

arsenicks commented Jul 15, 2024

What is the improvement or update to the Wiki you wish to see?

I've been looking for a way to fix the doc in the wiki but I'm unable to find how can I modify it myself and create a PR so I create this bug. If you can point me in the right direction, I would be able to fix it by myself and submit next time!

I started using meisnate12/plex-image-cleanup few weeks ago, so I just realized the repo has been renamed/moved under the kometa-team which is great but the documentation is in a weird state right now!

Here's a list:
In the Kometa doc: https://metamanager.wiki/en/latest/kometa/scripts/imagemaid/. The image to use is "kometateam/imagemaid" which fail when you try to pulll it with docker compose at least, because it cannot find the ":latest" tag. There's only develop tag for now so I don't know if the image is ready to be pushed/tagged as latest or if we need to fix the doc with "image: kometateam/imagemaid:develop" for now but anyway, there's something to clarify there!

Most of the meisnate12/plex-image-cleanup original readme should be fix to reflect the rebranding and at least explain it so people won't get confused but I think I'll try to change it by myself and submit a PR.

Does the docs page already exist? Please link to it.

https://metamanager.wiki/en/latest/kometa/scripts/imagemaid/

@arsenicks arsenicks added documentation Issue is related to documentation status:not-yet-viewed I haven't reviewed the Feature or Bug yet labels Jul 15, 2024
@chazlarson
Copy link
Contributor

I'm unable to find how can I modify it myself and create a PR

  1. fork the repo [kometa for the wiki, imagemaid for the readme]
  2. create a branch off the nightly branch
  3. make your changes; wiki files are in the docs directory
  4. commit your changes to your branch in your fork
  5. create a pull request into the main repo on the nightly branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issue is related to documentation status:not-yet-viewed I haven't reviewed the Feature or Bug yet
Projects
None yet
Development

No branches or pull requests

3 participants