Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TVShows overlays with total_runtime don't update at show and season level every time a new episode is released/added #2186

Open
joca879 opened this issue Aug 11, 2024 · 15 comments
Assignees
Labels
bug Bug is with Plex Meta Manager status:not-yet-viewed I haven't reviewed the Feature or Bug yet

Comments

@joca879
Copy link

joca879 commented Aug 11, 2024

Version Number

2.0.2-build26 (Docker: nightly)

What branch are you on?

nightly

Describe the Bug

TVShows overlays with total_runtime don't update at show and season level every time a new episode is released/added

Relevant Collection/Overlay/Playlist Definition

No response

Logs

No response

@joca879 joca879 added bug Bug is with Plex Meta Manager status:not-yet-viewed I haven't reviewed the Feature or Bug yet labels Aug 11, 2024
@meisnate12
Copy link
Member

are you wanting kometa to run automatically when a new episode is added so it can update the overlay or are you saying that after a new episode is added and kometa is run that the new runtime isnt replacing the old runtime?

@chazlarson
Copy link
Contributor

I reproduced this in my test library.

The issue is that when you add new episodes to a season, neither the season nor show runtime overlays change.

https://discord.com/channels/822460010649878528/1272191038169284649

When I reproed it, I added a second season, and the show runtime overlay was not updated.

@meisnate12
Copy link
Member

#If you force the reapply does it update properly? If so then it just needs to be added to what triggers an update

@joca879
Copy link
Author

joca879 commented Aug 12, 2024

are you wanting kometa to run automatically when a new episode is added so it can update the overlay or are you saying that after a new episode is added and kometa is run that the new runtime isnt replacing the old runtime?

When a new episode is added and kometa runs at 4AM, the total runtime of the season and show posters overlay are not updated with the adicional time from the new episode

@joca879
Copy link
Author

joca879 commented Aug 12, 2024

#If you force the reapply does it update properly? If so then it just needs to be added to what triggers an update

I've put the reapply_overlay: true on the config.yml and it updates... but it forces the reapply of all the shows and season overlays, not only the ones that have changed as result of a new episode being released/added to the show

@joca879
Copy link
Author

joca879 commented Aug 12, 2024

Maybe there's a need for some code in the runtime.yml so that if there's a new value to the total_runtime it updates the corresponding overlay on the season and on the show posters

@meisnate12
Copy link
Member

try using #2189 and see if it fixes the issue. its linked to docker with the total_runtime_trigger tag

@joca879
Copy link
Author

joca879 commented Aug 12, 2024

So I just have to update Kometa to the latest nightly version and try it? Or do I have to change something in the runtime.yml file to achieve it?

@chazlarson
Copy link
Contributor

chazlarson commented Aug 12, 2024

So I just have to update Kometa to the latest nightly version and try it? Or do I have to change something in the runtime.yml file to achieve it?

You'd have to update Kometa to that specific PR version; that has not been merged into nightly as yet.

@joca879
Copy link
Author

joca879 commented Aug 13, 2024

So I just have to update Kometa to the latest nightly version and try it? Or do I have to change something in the runtime.yml file to achieve it?

You'd have to update Kometa to that specific PR version; that has not been merged into nightly as yet.

Ok, I'll wait for the merging of the PR. Thanks

@YozoraXCII
Copy link
Contributor

YozoraXCII commented Aug 13, 2024

total_runtime_trigger

You would run against kometateam/kometa:total_runtime_trigger which should already be available, total_runtime_trigger is the name of the image, similar to nightly and develop

We don't want to update nightly with something that may be broken, so we set up a new image specifically for you to test this which we will then roll into nightly.

@joca879
Copy link
Author

joca879 commented Aug 13, 2024

Ok. I will test that image when I get home and see if it works when a new episode is released. I'll keep you posted. Thanks

@YozoraXCII
Copy link
Contributor

Ok. I will test that image when I get home and see if it works when a new episode is released. I'll keep you posted. Thanks

Any luck with this? :)

@joca879
Copy link
Author

joca879 commented Aug 14, 2024

Ok. I will test that image when I get home and see if it works when a new episode is released. I'll keep you posted. Thanks

Any luck with this? :)

I've installed the image like you suggested and set the reapply_overlay: false in the config.yml.
Unfortunatelly, I did not had new episodes released/added yesterday in the TVShows I have in my library, so I did not see any change.
If today the same happens, I'll create a test library for it and try it.
I'll keep you posted. Thanks

@joca879
Copy link
Author

joca879 commented Aug 14, 2024

I've just runned Kometa with the total_runtime_trigger image and it updates the show and season posters overlays with the actual total runtime when there's a new episode added to the TVShow.
Thanks @meisnate12 for implementing this update and thanks @chazlarson and @YozoraXCII for the help and guidance! :)

meisnate12 added a commit that referenced this issue Aug 16, 2024
Co-authored-by: GitHub Action <action@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug is with Plex Meta Manager status:not-yet-viewed I haven't reviewed the Feature or Bug yet
Projects
None yet
Development

No branches or pull requests

4 participants