Empty "orders" field when "best_orders" is called at launch

[naezith]

We need to parse the URL parameters at the web project to fill out the swap forms. The target/buy coin is selected as an order on the Taker form. That requires a best_orders call with the sell coin.

"coin": "LTC",
"action": "sell",
"request_by": {
    "type": "number",
    "value": 1
}

It's called immediately at launch (mm2 status being 3, rpcIsUp), orders field in the response is empty:

I solved the frontend issue by polling KMD orders a few times until it gives a proper response, then initiating the parsing. So this is not urgent at all. I am opening this issue just to note it.

macOS Chrome Web build (wasm)
main 35e9239

[mariocynicys]

This happens when no peer responds to our request

komodo-defi-framework/mm2src/mm2_p2p/src/behaviours/atomicdex.rs

Line 246 in d1a8ea7

if response_tx.send(None).is_err() {

We are probably not yet connected via the p2p network yet.

An error could be returned here instead of just returning an empty orders list:

komodo-defi-framework/mm2src/mm2_main/src/lp_ordermatch/best_orders.rs

Line 333 in a538a02

if let Some((p2p_response, peer_id)) = best_orders_res {

This will still require polling kdf while at startup but that's better than kdf polling the p2p network internally and hanging the RPC request.