fix(konnect): do not set owner relationship between ControlPlane and its config entities#1099
Merged
tao12345666333 merged 7 commits intomainfrom Feb 14, 2025
Merged
fix(konnect): do not set owner relationship between ControlPlane and its config entities#1099tao12345666333 merged 7 commits intomainfrom
tao12345666333 merged 7 commits intomainfrom
Conversation
pmalek
force-pushed
the
cpref-cascade-delete
branch
from
a3692a9 to
1f982ca
Compare
1 task
pmalek
force-pushed
the
cpref-cascade-delete
branch
from
1f982ca to
af147ea
Compare
pmalek
force-pushed
the
cpref-cascade-delete
branch
2 times, most recently
from
0fe0e5a to
f235488
Compare
pmalek
force-pushed
the
cpref-cascade-delete
branch
2 times, most recently
from
c42bae2 to
848ac5a
Compare
pmalek
force-pushed
the
cpref-cascade-delete
branch
from
5b9dd30 to
fcc9748
Compare
randmonkey
reviewed
Feb 12, 2025
pmalek
force-pushed
the
cpref-cascade-delete
branch
from
70f08a9 to
0fe2fbf
Compare
randmonkey
previously approved these changes
Feb 12, 2025
Contributor
randmonkey
left a comment
randmonkey
left a comment
There was a problem hiding this comment.
Genrally LGTM, but small places can be improved (not related to this PR though).
pmalek
force-pushed
the
cpref-cascade-delete
branch
2 times, most recently
from
b971baf to
cf8ae23
Compare
…its config entities
pmalek
force-pushed
the
cpref-cascade-delete
branch
from
cf8ae23 to
02f7c23
Compare
randmonkey
previously approved these changes
Feb 14, 2025
tao12345666333
previously approved these changes
Feb 14, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tao12345666333
dismissed stale reviews from randmonkey and themself
via
ad6faef
tao12345666333
previously approved these changes
Feb 14, 2025
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
tao12345666333
force-pushed
the
cpref-cascade-delete
branch
from
ad6faef to
7908293
Compare
tao12345666333
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes
Uses condition reason from : Kong/kubernetes-configuration#261
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes