fix(runloop): query args not forwarded bug

[chirag-manwani]

Summary

This PR fixes the issue described in #11325

Checklist

• The Pull Request has tests

Full changelog

Fix query args handling code introduced in this commit.

Issue reference

Fix #11325

[CLAassistant]

All committers have signed the CLA.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
11 out of 12 committers have signed the CLA.

✅ vm-001
✅ flrgh
✅ oowl
✅ chronolaw
✅ windmgc
✅ ADD-SP
✅ samugi
✅ curiositycasualty
✅ outsinre
✅ zhongweiy
✅ hanshuebner
❌ chirag-manwani
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[chirag-manwani]

@samugi Can this change be released in the next patch version of Kong 3.3.x?

[oowl]

@samugi Can this change be released in the next patch version of Kong 3.3.x?

In general, we do not do this backport to the old kong community old version.

[oowl]

Mostly is Okay for me, Please fix failure CI!

[chirag-manwani]

@samugi @oowl Could you approve the workflow runs once more?

[chirag-manwani]

The DB less integration test is still failing, and I am unsure as to why. Should this test be skipped for db less?

[chirag-manwani]

I noticed that the tests I was running on local were only running for postgres. Once I made them run for dbless, the tests failed. On further search I found that the route I am creating is being created, but the plugin I am applying on that route is not being created.
Is there something wrong in the way I've setup the test?

Update:
NVM, I found why the plugin was not being set. The complete config for the test is being set in insert_routes. In case of db strategy, the bp variable is set to admin_api and setting config outside this function works fine. In case of dbless, the config set until that point by bp variable is used to create a declarative config, and since I was setting the config after the insert_routes function was called, the plugin config was ignored.

[chirag-manwani]

@samugi @oowl Please allow the workflow once more. I've updated the tests to work for dbless mode also. All tests should pass now.

[chirag-manwani]

@oowl @samugi
An unrelated test case failed. Is this a flaky test case? The tests should just be re-run in this case right?

FAILED  spec/02-integration/05-proxy/10-balancer/01-healthchecks_spec.lua:1893: Ring-balancer #postgres #healthchecks (#cluster #db) #hostname #healthchecks perform active health checks on targets that resolve to the same IP -- automatic recovery #http
...ntegration/05-proxy/10-balancer/01-healthchecks_spec.lua:1995: Expected values to be near.
Passed in:
(number) 5
Expected:
(number) 10 +/- 3

[chirag-manwani]

Please re-run the failed workflow when you have the time.
@oowl @samugi

[samugi]

thank you @chirag-manwani for your efforts writing this test.
Would you mind moving it out of the 02-router_spec.lua file, since this is not exactly a router test? I believe it would be appropriate to create a new test file, e.g. spec/02-integration/05-proxy/32-query-params_spec.lua.

For this specific change, feel free to use the default output of helpers.each_strategy(), which won't require extra work to make the dbless test pass, so that an implementation similar to your first attempt should work just fine.

[chirag-manwani]

@samugi Added the test case in a separate file.

[chirag-manwani]

@samugi
All tests have passed, please merge the PR. I have one additional request though. If possible please make this change available in any patch version of Kong 3.3.x

[oowl]

LGTM!

[samugi]

thanks again for your contribution @chirag-manwani! As @oowl also mentioned before I believe there is no plan to backport this right now, but we will update you here if that changes.