Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor bug fix: Fix error message for retries #13605

Merged
merged 5 commits into from
Oct 11, 2024
Merged

Minor bug fix: Fix error message for retries #13605

merged 5 commits into from
Oct 11, 2024

Conversation

AD7six
Copy link
Contributor

@AD7six AD7six commented Sep 2, 2024 •
edited by liverpool8056
Loading

Summary

Fix this error message which refers to the wrong variable:

if retries < 0 or retries > 32767 then
      error("port must be an integer between 0 and 32767: given " .. retries, 2)

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - (No user facing impact, no PR created)

Issue reference

This is an unreported bug.

@CLAassistant
Copy link

CLAassistant commented Sep 2, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added core/pdk cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Sep 2, 2024
@team-eng-enablement team-eng-enablement added the author/community PRs from the open-source community (not Kong Inc) label Sep 2, 2024
@liverpool8056 liverpool8056 mentioned this pull request Sep 12, 2024
Closed
3 tasks
@liverpool8056
Copy link
Contributor

@AD7six good catch. Please add a changelog under changelog/unrelease/kong

@AD7six
fix: Correct error message for retries variable
fc44cb0 
The variable being tested is retries, but the error message refers to
port.
@AD7six
tests: Update test expectations for retries variable
b70ad5f
@AD7six
Copy link
Contributor Author

AD7six commented Sep 12, 2024 •
edited
Loading

Sure thing. Here's another minor doc-error I noticed along the way :) #13658

@AD7six
Copy link
Contributor Author

AD7six commented Oct 11, 2024 •
edited
Loading

@liverpool8056 👋 what is required to get this MR merged :) ?

If it's waiting for some action from me - what is that action?

gszr
gszr approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@gszr gszr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@gszr
Copy link
Member

gszr commented Oct 11, 2024

Thanks for your first contribution, @AD7six! Here's to many more 🦍

@gszr gszr merged commit 4c472c2 into Kong:master Oct 11, 2024
26 checks passed
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

@gszr
Copy link
Member

gszr commented Oct 11, 2024

@liverpool8056 👋 what is required to get this MR merged :) ?

If it's waiting for some action from me - what is that action?

All PRs require two reviews : )

@AD7six AD7six deleted the ad-retries-port branch October 11, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gszr gszr gszr approved these changes

@liverpool8056 liverpool8056 liverpool8056 approved these changes

Assignees
No one assigned
Labels
author/community PRs from the open-source community (not Kong Inc) cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/pdk size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AD7six @CLAassistant @liverpool8056 @gszr @team-gateway-bot @team-eng-enablement