-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(helpers): separate cmd&pid functions #13648
Conversation
I suppose we will also update the user of those utilities to directly import from separated files, to avoid unnecessary dependencies? |
It may cause incompatible issues, currently we will not change the interface of helpers. |
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13648-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13648-to-master-to-upstream
git checkout -b cherry-pick-13648-to-master-to-upstream
ancref=$(git merge-base c498f41dc03f7a04aaf3df24c59e01ff5e39c339 3bd7ce5b076eee1f3658187864998c3c53f1dafc)
git cherry-pick -x $ancref..3bd7ce5b076eee1f3658187864998c3c53f1dafc |
Summary
KAG-5244
Move echo server related functions since they are using
cmd.stop_kong()
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]