fix(dbless): construct right pk string for entity with multiple primary keys #13826
+21
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/db
schema-change-noteworthy
cherry-pick kong-ee
team-gateway-bot
added
the
author/community
chronolaw
changed the title
chronolaw
changed the title
chronolaw
approved these changes
Nov 4, 2024
team-eng-enablement
removed
the
author/community
|
@chobits is working on fixing this PR, do not merge yet. |
…imary keys For the entity with multiple primary keys, like consumer_group_consumers, the pk_string() function construct incorrect pk string like `table: 0x028a49eda0:table: 0x0289c257b8`. Because it does not extract the internal id value. Here, we fix it with original lmdb logic get_cache_key_value(). Note this method directly gets id field name.
…tring (#10623) * fix(sync): don't use an upvalue request_aware_table to construct pk_string * fix: use local upvalue {}
chobits
force-pushed
the
fix/sync_kag_5732
branch
from
1ac52f4
to
4656916
Compare
|
ready for reviewing, Still need another fix to iterate the foreign pk strings. TODO kag: https://konghq.atlassian.net/browse/KAG-5750 |
chronolaw
approved these changes
Nov 5, 2024
chobits
commented
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For the entity with multiple primary keys, like consumer_group_consumers, the pk_string() function construct incorrect pk string like
table: 0x028a49eda0:table: 0x0289c257b8. Because it does not extract the internal id value. Here, we fix it with original lmdb logic get_cache_key_value(). Note this method directly gets id field name.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix KAG-5732