fix(plugin/cors): treat empty Origin header same as missing header #14368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
team-eng-enablement
added
the
author/community
1 task
StarlightIbuki
approved these changes
Apr 9, 2025
|
Hi @StarlightIbuki 👋, a friendly ping to let me know if there's anything I can clarify or adjust to move this forward. |
chronolaw
reviewed
Apr 16, 2025
changelog/unreleased/kong/fix-cors-allow-empty-string-origin.yml
Outdated
Show resolved
Hide resolved
|
@dingjiayi Hi. Please address the new comments. Our policy requires 2 approvals from maintainers to merge a PR. |
chronolaw
changed the title
chronolaw
approved these changes
Apr 17, 2025
StarlightIbuki
approved these changes
Apr 18, 2025
StarlightIbuki
added
the
cherry-pick kong-ee
|
Thanks for your contribution! After all CI goes green this PR will be merged |
chobits
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change ensures that an empty Origin header (
Origin: "") is treatedthe same way as a missing Origin header, fixing inconsistent behavior
between these two cases.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #14352