Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Wallet Connect #281

Closed
12 tasks done
lw-cdm opened this issue Dec 5, 2022 · 6 comments · Fixed by #911
Closed
12 tasks done

Implement Wallet Connect #281

lw-cdm opened this issue Dec 5, 2022 · 6 comments · Fixed by #911
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@lw-cdm
Copy link
Contributor

lw-cdm commented Dec 5, 2022

Implement Wallet Connect following what implemented on extension (Koniverse/SubWallet-Extension#1497):

  • Implement scanner
  • Implement deep-link

Detail:

  • Component:

  • Dual Logo (change the center icon for WalletConnect confirmation)

  • WCAccountSelect

  • WCNetworkSelect

  • WCNetworkSupported

  • WCAvatarGroup

  • Screen:

  • ConnectList

  • ConnectWalletConnect

  • ConnectDetail

  • WalletConnectConfirmation

  • ScanToConnectWalletConnect

@lw-cdm lw-cdm added enhancement New feature or request mobile labels Dec 5, 2022
@saltict saltict changed the title Support signing between apps Support signing between apps via Wallet Connect Dec 9, 2022
@saltict saltict added the w49-50 label Dec 9, 2022
@saltict saltict modified the milestone: Milestone 4 Dec 9, 2022
@saltict saltict added w51-52 and removed w49-50 labels Dec 9, 2022
@lw-cdm lw-cdm added this to the Milestone 5 milestone Dec 12, 2022
@lw-cdm lw-cdm added w51-52 and removed w51-52 labels Dec 23, 2022
@sokol142 sokol142 removed the w51-52 label Dec 26, 2022
@hieudd hieudd modified the milestones: Milestone 5, Milestone 6 Apr 13, 2023
@saltict saltict changed the title Support signing between apps via Wallet Connect Implement Wallet Connect Jun 23, 2023
@Sokol142196 Sokol142196 removed their assignment Jul 17, 2023
@Sokol142196 Sokol142196 modified the milestones: Milestone 6, Milestone 7 Jul 20, 2023
@Sokol142196
Copy link

Sokol142196 commented Jul 23, 2023

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-203-911-merge-2023-07-21T09-38-39.ipa

Please check:

  • Can not connect WalletConnect in case support both Substrate & EVM network
    • Actual: Do not show select account field

Image

  • Still displaying submitting after connecting failed in case connection exists

Image

  • UI bugs

Image

Image

Image


Case: connect app to app

  • Still show "invalid URI" when sign transaction
  • Show "connect exists" when connect WalletConnect on the first time
  • Handle case connect WalletConnect when do not create master password yet
    • Steps:

      1. Install SubWallet
      2. Go to the dApp (support connect by WalletConnect via deeplink)
      3. On the dApp, click connect with SubWallet
      4. Observe the screen displaed in SubWallet
    • Actual: Show the approve request (create one account to connect) but do not create account cause do not create master password

    • Expect: If user do not create master password yet, when click on "Create one" button then navigate user to the create master password

@Sokol142196
Copy link

Sokol142196 commented Jul 28, 2023

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-204-911-merge-2023-07-27T06-13-58.ipa

Please check issues:

  • Do not show the popup confirmation when opening modal (Scan QR code, Receive addess...)

    Reproduce the behavior
    Pre-condition: Connect with WallectConnect successfully

    Steps:

    1. Open the app
    2. Go to the Select token to get the address or Scan QR code...
    3. On the dApp, send a request to SubWallet (sign request)
    4. Observe the SubWallet

    Actual: Do not show popup confirmation

    • And: Do not redirect when accessing to Setting menu or browser
  • UI bug when have multiple accounts on list

Image

  • Do not show err message in case connect to ConnectWallet is failed when scanning from the Setting screen

    • Actual: Back to Setting screen then show err message
    • Expect: Show error message on the Scan QR code screen
  • Redirect incorrect screen when click Back on the scan QR from Setting screen in case have connection

    • Actual: Back to Setting screen
    • Expect: Back to List connection screen
  • Show popup confirmation in case not support method (follow the issue: Signature method handling is not supported for WalletConnect SubWallet-Extension#1674) => improve later

@Sokol142196
Copy link

Sokol142196 commented Jul 29, 2023

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-204-911-merge-2023-07-29T11-10-45.ipa

Please check:

  • Handle case camera access permission
    • Actual: If user select denied permission then can not use app continuing

Image

  • Do not navigate in case modal overlap modal on iOS device
    Steps:

    1. Open the SubWallet app
    2. Connect to dApp via WalletConnect successfully
    3. On the SubWallet app, go to the History detail or QR code screen
    4. On the dApp, perform any transaction
    5. On the SubWallet app: approve transaction then navigate to the other screen

    Actual: Do not navigate

RPReplay_Final1690631474.MP4

=> Solution: Hot fixed before then fixed this issue in #928

@ThaoNguyen998
Copy link

ThaoNguyen998 commented Aug 7, 2023

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-205-911-merge-2023-08-07T02-44-00.apk
Device test: MI 8 Lite

  • Do not show confirmation when connect wallet
  • Navigate incorrect screen
    Pre-condition:
  • Enable Pin code feature
  • App lock = Immediately
    Steps:
  1. Open the Welcome back screen
  2. Perform forget all account and observe the displayed screen
  3. Close app and re-open app

Actual: https://share.icloud.com/photos/082HaP_Vf3WE9Mc2QxF1cRbJQ
In step 2: Do not show Welcome screen
In step 3: Show Welcome screen

  • Flash Wallet connect screen
281.mp4
  • Skip auto focus Search in case open Wallet connect list screen

@ThaoNguyen998
Copy link

ThaoNguyen998 commented Aug 9, 2023

@ThaoNguyen998
Copy link

@hieudd hieudd modified the milestones: Milestone 7, Milestone 6 Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants