Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update new Send Fund UI #815

Closed
7 tasks done
saltict opened this issue Jun 23, 2023 · 5 comments · Fixed by #863 or #937
Closed
7 tasks done

Update new Send Fund UI #815

saltict opened this issue Jun 23, 2023 · 5 comments · Fixed by #863 or #937
Assignees
Milestone

Comments

@saltict
Copy link
Contributor

saltict commented Jun 23, 2023

  • Style
  • Scan QR from home
  • Step view
  • Validate by step view
  • Amount input
  • Auto calculate amount to $
  • In "Amount view", token selector and des-chain selector will limit options to any chain that support the recipient address
@ThaoNguyen998
Copy link

ThaoNguyen998 commented Jul 6, 2023

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-192-863-merge-2023-07-06T02-12-27.ipa
@lw-cdm Please check:

  • Bug auto select Send from, Send to
    Expect: Do not auto Send from, Send to

  • Do not show a message in case of a change destination chain
    Steps:

  1. Go to the transfer screen
  2. Select send from, send to = substrate address
  3. Change the destination chain = Moonbeam
  4. Touch the Next button and then observe the displayed screen
  5. Input a valid amount
  6. Touch the Transfer button

Actual:
In step 3: Do not show a message "The recipient address must be EVM type"
In step 4: Navigate to the Amount screen
In Step 6: Show the message error

815_1.mp4

Expect: Automatic check data when changing the destination chain

  • Re-check the list token on the Amount screen
  • Don't allow autofocus Send to
  • Update size logo address Send from
  • Navigate the incorrect screen when performing a transaction successfully
  • Do not validate data in case of scan QR on token screen
    Pre-condition: Specific account = EVM account

Steps:

  1. Go to the Token screen
  2. Perform scan QR = substrate address
  3. Observe the displayed screen

Actual: https://github.com/Koniverse/SubWallet-Mobile/assets/117999489/86bc9a95-5bf6-4143-96e6-9b7e2a48884c

  • Incorrect token default when select account EVM

Image

@ThaoNguyen998
Copy link

ThaoNguyen998 commented Jul 11, 2023

@Sokol142196 Sokol142196 modified the milestones: Milestone 6, Milestone 7 Jul 20, 2023
@Sokol142196
Copy link

Sokol142196 commented Jul 25, 2023

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-203-863-merge-2023-07-24T04-11-48.ipa

Please check:

@Sokol142196
Copy link

Sokol142196 commented Jul 28, 2023

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-204-863-merge-2023-07-27T09-07-26.ipa

Devive test: IP 8 Plus (15.5)

Please check issues:

  • Still allow user send on chain with same account

    To reproduce the behavior

    1. Go to the Send fund screen
    2. In Step 1, input the sender same as receiver and input valid data for remain fields
    3. Click Next to next step
    4. In step 2, change Destination chain: Destination chain = Origin chain
    5. Input valid amount then click Transfer button

    Actual: Still allow send fund

Image

Expect: Filter Destination chain by Origin chain and recipient address

  • Blur all action when submitting

@ThaoNguyen998
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment