fix ArrayIndexOutOfBoundsException in FileHeaderUtils

oraveczandrew · oraveczandrew · commit 5abb8c9daf46 · 2025-02-28T20:03:47.000+01:00
diff --git a/src/main/java/the/bytecode/club/bytecodeviewer/util/FileHeaderUtils.java b/src/main/java/the/bytecode/club/bytecodeviewer/util/FileHeaderUtils.java
@@ -30,6 +30,8 @@ public class FileHeaderUtils
 
     public static boolean doesFileHeaderMatch(byte[] bytes, int fileHeader)
     {
+        if (bytes.length < 4) return false;
+
         int bytesHeader = ((bytes[0] & 0xFF) << 24)
             | ((bytes[1] & 0xFF) << 16)
             | ((bytes[2] & 0xFF) << 8)

Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,8 @@ public class FileHeaderUtils`
`30`	`30`
`31`	`31`	`public static boolean doesFileHeaderMatch(byte[] bytes, int fileHeader)`
`32`	`32`	`{`
	`33`	`+ if (bytes.length < 4) return false;`
	`34`	`+`
`33`	`35`	`int bytesHeader = ((bytes[0] & 0xFF) << 24)`
`34`	`36`	`\| ((bytes[1] & 0xFF) << 16)`
`35`	`37`	`\| ((bytes[2] & 0xFF) << 8)`