Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [1.9.0--3b]: popup preview doesn't work if a page has raw html at start. #581

Open
soymadip opened this issue Feb 8, 2025 · 9 comments
Labels
bug Something isn't working has-link This issue provides a link (possibly to a resource helpful to reproduce the issue)

Comments

@soymadip
Copy link

soymadip commented Feb 8, 2025

What happened?

if we have a page that has raw html at start of the page, the popup preview (the one that pops up when you hover over a link) shows blnk page.

i have a page with this content: -

<div align="center" style="padding-top:30vh;">
<br><br>
<h1> Methods are not yet documented.</h1>
<a href="https://soymadip.me/KireiSakura-Kit/faq.html#4._How_to_help_writing_docs?_0">Wanna help?</a>
</div>

now i tried to popup review in exported site & obisidian:-
(1st in website & then obsidian)

obsidian-webpage-bug-popup-preview.mp4

the popup comes blank in the website.

Reproduction

  1. write some raw html code in any page.
  2. now in another page add an internal link to that page.
  3. now in obsidian preview the link using ctrl/cmd + hover over the link. The popup will show the page preview.
  4. now export both pages using extension. run webpage & hover over the internal link. (as a quich suggestion, it needs some improvements), popup will show. but the popup will be blank.

Last Working Version

No response

Version

1.9.0--3b

Operating System

Linux 6.12.10-arch1-1 #1 SMP PREEMPT_DYNAMIC Sat, 18 Jan 2025 02:26:57 +0000 x86_64 GNU/Linux

Obsidian Version

1.8.4

Which browsers can you reproduce this in?

Firefox, Chrome, Microsoft Edge

Relevant log output

Log:
[INFO] 	Including stylesheet: css-settings-manager
Progress	{"fraction":0,"message":"Compiling css classes","subMessage":"Scanning: deferred.css"}
Progress	{"fraction":0,"message":"Compiling css classes","subMessage":"Scanning: main-styles.css"}
Progress	{"fraction":0,"message":"Compiling css classes","subMessage":"Scanning: supported-plugins.css"}
Progress	{"fraction":0,"message":"Compiling css classes","subMessage":"Scanning: global-variable-styles.css"}
Progress	{"fraction":0,"message":"Compiling css classes","subMessage":"Scanning: theme.css"}
Progress	{"fraction":0,"message":"Compiling css classes","subMessage":"Scanning: other-plugins.css"}
Progress	{"fraction":0,"message":"Compiling css classes","subMessage":"Scanning: obsidian.css"}
Progress	{"fraction":0,"message":"Compiling css classes","subMessage":"Scanning: snippets.css"}
Progress	{"fraction":0,"message":"Compiling css classes","subMessage":"Scanning: mathjax.css"}
Progress	{"fraction":0,"message":"Filtering classes","subMessage":"..."}
Progress	{"fraction":0,"message":"Sorting classes","subMessage":"..."}
Progress	{"fraction":0,"message":"Collecting valid classes","subMessage":"Scanning: theme-dark"}
Progress	{"fraction":0,"message":"Collecting valid classes","subMessage":"Scanning: mod-linux"}
Progress	{"fraction":0,"message":"Collecting valid classes","subMessage":"Scanning: obsidian-app"}
Progress	{"fraction":0,"message":"Collecting valid classes","subMessage":"Scanning: show-ribbon"}
Progress	{"fraction":0,"message":"Collecting valid classes","subMessage":"Scanning: show-view-header"}
Progress	{"fraction":0,"message":"Collecting valid classes","subMessage":"Scanning: css-settings-manager"}
Progress	{"fraction":0,"message":"Collecting valid classes","subMessage":"Scanning: callout-style-customize"}
Progress	{"fraction":0,"message":"Collecting valid classes","subMessage":"Scanning: is-focused"}
Progress	{"fraction":0,"message":"Cleanup classes","subMessage":"..."}
Progress	{"fraction":0,"message":"Filter duplicate classes","subMessage":"53 classes"}
Progress	{"fraction":0,"message":"Classes done","subMessage":"..."}


Settings:
{
  "settingsVersion": "0.0.0",
  "exportOptions": {
    "createDocumentContainer": true,
    "keepModHeaderFooter": false,
    "addPageIcon": false,
    "unifyTitleFormat": true,
    "createPusherElement": true,
    "makeHeadersTrees": true,
    "postProcess": true,
    "displayProgress": true,
    "inlineHTML": false,
    "exportPath": "/home/soymadip/Documents/git/KireiSakura-Kit/docs",
    "addBodyClasses": true,
    "addMathjaxStyles": true,
    "addHeadTag": true,
    "backlinkOptions": {
      "enabled": true,
      "unavailable": false,
      "displayTitle": "Backlinks",
      "featurePlacement": {
        "selector": ".footer",
        "type": "start"
      }
    },
    "tagOptions": {
      "enabled": true,
      "unavailable": false,
      "displayTitle": "",
      "featurePlacement": {
        "selector": ".header .data-bar",
        "type": "end"
      },
      "showInlineTags": true,
      "showFrontmatterTags": true
    },
    "aliasOptions": {
      "enabled": true,
      "unavailable": false,
      "displayTitle": "",
      "featurePlacement": {
        "selector": ".header .data-bar",
        "type": "start"
      }
    },
    "propertiesOptions": {
      "enabled": true,
      "unavailable": false,
      "displayTitle": "Properties",
      "featurePlacement": {
        "selector": ".header",
        "type": "start"
      }
    },
    "fileNavigationOptions": {
      "enabled": true,
      "unavailable": false,
      "displayTitle": "",
      "featurePlacement": {
        "selector": "#left-sidebar-content",
        "type": "end"
      },
      "showCustomIcons": true,
      "showDefaultFolderIcons": false,
      "showDefaultFileIcons": false,
      "defaultFolderIcon": "lucide//folder",
      "defaultFileIcon": "lucide//file",
      "defaultMediaIcon": "lucide//file-image",
      "exposeStartingPath": false,
      "includePath": "site-lib/html/file-tree.html"
    },
    "searchOptions": {
      "enabled": true,
      "unavailable": false,
      "displayTitle": "Search Docs...",
      "featurePlacement": {
        "selector": "#left-sidebar .topbar-content",
        "type": "start"
      }
    },
    "outlineOptions": {
      "enabled": true,
      "unavailable": false,
      "displayTitle": "Outline",
      "featurePlacement": {
        "selector": "#right-sidebar-content",
        "type": "end"
      },
      "startCollapsed": false,
      "minCollapseDepth": "100"
    },
    "themeToggleOptions": {
      "enabled": true,
      "unavailable": false,
      "displayTitle": "",
      "featurePlacement": {
        "selector": "#right-sidebar .topbar-content",
        "type": "start"
      }
    },
    "graphViewOptions": {
      "enabled": true,
      "unavailable": false,
      "displayTitle": "Graph View",
      "featurePlacement": {
        "selector": "#right-sidebar-content",
        "type": "start"
      },
      "showOrphanNodes": true,
      "showAttachments": false,
      "allowGlobalGraph": true,
      "allowExpand": true,
      "attractionForce": 1,
      "linkLength": 15,
      "repulsionForce": 85,
      "centralForce": 2,
      "edgePruning": 100,
      "minNodeRadius": 3,
      "maxNodeRadius": 7
    },
    "sidebarOptions": {
      "enabled": true,
      "unavailable": false,
      "allowResizing": true,
      "allowCollapsing": true,
      "rightDefaultWidth": "19em",
      "leftDefaultWidth": "19em"
    },
    "customHeadOptions": {
      "enabled": false,
      "unavailable": false,
      "displayTitle": "",
      "featurePlacement": {
        "selector": "head",
        "type": "end"
      },
      "sourcePath": "",
      "includePath": "site-lib/html/custom-head.html"
    },
    "documentOptions": {
      "enabled": true,
      "unavailable": false,
      "allowFoldingLists": true,
      "allowFoldingHeadings": true,
      "documentWidth": "43em"
    },
    "rssOptions": {
      "enabled": true,
      "unavailable": false,
      "siteUrl": "http://kireisakura.soymadip.me/",
      "siteName": "Docs | KireiSakura Kit",
      "authorName": "soymadip"
    },
    "relativeHeaderLinks": false,
    "includeJS": true,
    "includeCSS": true,
    "inlineMedia": false,
    "inlineCSS": false,
    "inlineJS": false,
    "inlineFonts": false,
    "inlineOther": false,
    "combineAsSingleFile": false,
    "offlineResources": false,
    "themeName": "",
    "slugifyPaths": true,
    "flattenExportPaths": false,
    "fixLinks": true,
    "faviconPath": "../icon.png",
    "iconEmojiStyle": "Native",
    "exportRoot": "",
    "includePluginCss": [],
    "includeStyleCssIds": [],
    "autoDisposeWebpages": true
  },
  "logLevel": "warning",
  "titleProperty": "title",
  "rssDateProperty": "date",
  "onlyExportModified": true,
  "deleteOldFiles": true,
  "exportPreset": "online",
  "openAfterExport": false,
  "filePickerBlacklist": [
    "(^|\\/)node_modules\\/",
    "(^|\\/)dist\\/",
    "(^|\\/)dist-ssr\\/",
    "(^|\\/)\\.vscode\\/"
  ],
  "filePickerWhitelist": [
    "\\.\\w+$"
  ]
}

Enabled Plugins:
	Style Settings
	Advanced Tables
	Webpage HTML Export
	Dataview
	BRAT

Additional Info

No response

@soymadip soymadip added the bug Something isn't working label Feb 8, 2025
Copy link

github-actions bot commented Feb 8, 2025

Thank you for reporting this issue. It is possible this issue has already been solved in the latest beta version.
Please try updating to the latest beta version of the plugin (1.9.0-3b) and see if the issue persists.

You can find the latest beta release here: https://github.com/KosmosisDire/obsidian-webpage-export/releases/tag/1.9.0-3b.
Instructions for installing are located in the readme.

If the problem continues after updating, please let us know, and we'll investigate further.

@github-actions github-actions bot added the has-link This issue provides a link (possibly to a resource helpful to reproduce the issue) label Feb 8, 2025
@github-actions github-actions bot changed the title [Bug]: popup preview doesn't work if a page has raw html at start. [Bug] [1.9.0--3b]: popup preview doesn't work if a page has raw html at start. Feb 8, 2025
@soymadip
Copy link
Author

soymadip commented Feb 8, 2025

Thank you for reporting this issue. It is possible this issue has already been solved in the latest beta version. Please try updating to the latest beta version of the plugin (1.9.0-3b) and see if the issue persists.

You can find the latest beta release here: https://github.com/KosmosisDire/obsidian-webpage-export/releases/tag/1.9.0-3b. Instructions for installing are located in the readme.

If the problem continues after updating, please let us know, and we'll investigate further.

yes i am in beta version...

@KosmosisDire
Copy link
Owner

Thanks, so to be clear this only occurs when the content of the file is html. If it is markdown then it's fine?

@soymadip
Copy link
Author

soymadip commented Feb 10, 2025

Thanks, so to be clear this only occurs when the content of the file is html. If it is markdown then it's fine?

I far I tested, if the page in lnline link has html at the front popup fails to preview.

For example this page:-
https://github.com/soymadip/KireiSakura-Kit/blob/main/Assets/notes/terminology.md

Also like I wrote a h1 tag and made inline link of it, that has blank popup too

@soymadip
Copy link
Author

Thanks, so to be clear this only occurs when the content of the file is html. If it is markdown then it's fine?

i discovered another bug, when the preview opens, click to button at the top right corner to go to the popup page[in the redirect link].

the page will open but the popup will still be in the page.

@KosmosisDire
Copy link
Owner

@soymadip As far as the popup staying on the page, that is not a bug unless you mean it still stays even when your mouse leaves the popup. Do you think it makes more sense for the "go to" link to close the popup?

I see thhe problem with the popup being empty as well although I am not sure what is causing it. I will try to reproduce and fix it. Thanks for the report

@soymadip
Copy link
Author

@soymadip As far as the popup staying on the page, that is not a bug unless you mean it still stays even when your mouse leaves the popup. Do you think it makes more sense for the "go to" link to close the popup?

So for late reply, I was in some personal problems.

I was meaning that when we go to the page which is being previewed through the popup. The popup remains after the page is loaded.

@KosmosisDire
Copy link
Owner

Do you mean when clicking on the link, or when clicking on the icon on the popup?

@soymadip
Copy link
Author

soymadip commented Feb 21, 2025

Do you mean when clicking on the link, or when clicking on the icon on the popup?

i will do a screen record. I can't explain clearly i guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working has-link This issue provides a link (possibly to a resource helpful to reproduce the issue)
Projects
Development

No branches or pull requests

2 participants