Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"bcrypt" still mandatory to run the tests #1699

Closed
henning-schild opened this issue Feb 17, 2025 · 4 comments
Closed

"bcrypt" still mandatory to run the tests #1699

henning-schild opened this issue Feb 17, 2025 · 4 comments

Comments

@henning-schild
Copy link
Contributor

Starting from 3.4.0 'bcrypt' is an optional dependency at runtime. However it seems to still be mandatory to successfully run the tests.

Just ran into that on gentoo here https://bugs.gentoo.org/949850

The gentoo solution will likely be to add bcrypt as a build dependency when testing is enabled.

Just wanted to let you know. Maybe the tests can be changed so that bcrypt related tests are skipped gracefully when not available.

@pbiering
Copy link
Collaborator

fixed by #1700

@henning-schild
Copy link
Contributor Author

Thanks!

@henning-schild
Copy link
Contributor Author

Just wondering if

test = ["pytest>=7", "waitress", "bcrypt"]
needs changing as well

@pbiering
Copy link
Collaborator

Just wondering if

Radicale/pyproject.toml

Line 40 in 93970a1
test = ["pytest>=7", "waitress", "bcrypt"]
needs changing as well

In this context:

[project.optional-dependencies]
test = ["pytest>=7", "waitress", "bcrypt"]
bcrypt = ["bcrypt"]
ldap = ["ldap3"]

I would assume it's not causing any problems now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants