Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ETag Handling to Conform with HTTP Standard (Add Double Quotes) #318

Open
feteu opened this issue Dec 26, 2024 · 0 comments
Open

Fix ETag Handling to Conform with HTTP Standard (Add Double Quotes) #318

feteu opened this issue Dec 26, 2024 · 0 comments

Comments

@feteu
Copy link

feteu commented Dec 26, 2024

Hi @Krukov,

First of all, thank you for the great implementation of your caching mechanism. It really fills an important gap when compared to other libraries available.

I would like to raise an issue regarding the ETag implementation for the FastAPI middleware. It seems that the ETag is being correctly applied and added as a response header, but it doesn't fully adhere to the HTTP ETag standard. Specifically, the ETag is holding the hash without the necessary double quotes.

I’d like to propose an adjustment to ensure the proper handling of the ETag header:

  • Strip the double quotes from the incoming header here.
  • Add the double quotes when returning the request here.

Let me know your thoughts on this. I’d be happy to create a pull request and submit it for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant