Skip to content

Commit 313547f

Browse files
committed
Changed interface
1 parent 46c15f9 commit 313547f

File tree

3 files changed

+10
-12
lines changed

3 files changed

+10
-12
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,13 @@ dependencies {
3131
## Usage
3232

3333
```kotlin
34-
val target1 = SimpleTarget.Builder(this@MainActivity).setCoordinate(binding.fab)
34+
val target1 = SimpleTarget.Builder(this@MainActivity).setTarget(binding.fab)
3535
.setTitle("Floating Action Button")
3636
.setHighlightRadius(100f)
3737
.setDescription("This is the floating action button.")
3838
.build()
3939

40-
val target2 = SimpleTarget.Builder(this@MainActivity).setCoordinate(binding.firstText)
40+
val target2 = SimpleTarget.Builder(this@MainActivity).setTarget(binding.firstText)
4141
.setTitle("First text")
4242
.setDescription("This is the first text.")
4343
.setHighlightPadding(R.dimen.simple_hightlight_padding)
@@ -48,7 +48,7 @@ val target2 = SimpleTarget.Builder(this@MainActivity).setCoordinate(binding.firs
4848
})
4949
.build()
5050

51-
val target3 = SimpleTarget.Builder(this@MainActivity).setCoordinate(binding.secondText)
51+
val target3 = SimpleTarget.Builder(this@MainActivity).setTarget(binding.secondText)
5252
.setTitle("Second text")
5353
.setDescription("This is the second text.")
5454
.setMessageLayoutResId(R.layout.layout_instruction_simple_message_black)

example/src/main/java/co/kyash/androidtargetinstructions/example/MainActivity.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,13 @@ class MainActivity : AppCompatActivity() {
3636
}
3737

3838
private fun showInstructions() {
39-
val target1 = SimpleTarget.Builder(this@MainActivity).setCoordinate(binding.fab)
39+
val target1 = SimpleTarget.Builder(this@MainActivity).setTarget(binding.fab)
4040
.setTitle("Floating Action Button")
4141
.setHighlightRadius(100f)
4242
.setDescription("This is the floating action button.")
4343
.build()
4444

45-
val target2 = SimpleTarget.Builder(this@MainActivity).setCoordinate(binding.firstText)
45+
val target2 = SimpleTarget.Builder(this@MainActivity).setTarget(binding.firstText)
4646
.setTitle("First text")
4747
.setDescription("This is the first text.")
4848
.setHighlightPadding(R.dimen.simple_hightlight_padding)
@@ -53,12 +53,12 @@ class MainActivity : AppCompatActivity() {
5353
})
5454
.build()
5555

56-
val target3 = SimpleTarget.Builder(this@MainActivity).setCoordinate(binding.secondText)
56+
val target3 = SimpleTarget.Builder(this@MainActivity).setTarget(binding.secondText)
5757
.setTitle("Second text")
5858
.setDescription("This is the second text.")
5959
.setMessageLayoutResId(R.layout.layout_instruction_simple_message_black)
6060
.setHighlightHorizontalPadding(R.dimen.space_minus_16dp)
61-
.setStartDelayMillis(200L)
61+
.setStartDelayMillis(2000L)
6262
.build()
6363

6464
TargetInstructions.with(this@MainActivity)

library/src/main/java/co/kyash/targetinstructions/AbstractTargetBuilder.kt

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,19 +33,17 @@ abstract class AbstractTargetBuilder<T : AbstractTargetBuilder<T, S>, S : Target
3333

3434
abstract fun build(): S
3535

36-
fun setCoordinate(left: Float, top: Float, width: Float, height: Float): T {
36+
fun setTarget(left: Float, top: Float, width: Float, height: Float): T {
3737
this.left = left
3838
this.top = top
3939
this.width = width
4040
this.height = height
4141
return self()
4242
}
4343

44-
fun setCoordinate(view: View): T {
44+
fun setTarget(view: View): T {
4545
viewWeakReference = WeakReference(view)
46-
val location = IntArray(2)
47-
view.getLocationInWindow(location)
48-
return setCoordinate(location[0].toFloat(), location[1].toFloat(), view.width.toFloat(), view.height.toFloat())
46+
return self()
4947
}
5048

5149
fun setHighlightRadius(radius: Float): T {

0 commit comments

Comments
 (0)