Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/deanonymize-get-prop-funcs #57

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

mrufsvold
Copy link
Contributor

@mrufsvold mrufsvold commented Jan 26, 2024

I don't want to break the api, so I created a simple get_property function that looks up the correct function and then returns an anonymous function with "this" inserted in the first position.

I commented out a warning log about deprecation because basically every function call in the code base hits that warning at the moment. But once everything is moved to using direct function calls, we can turn on the warning to track down the last of them.

To be clear: I didn't change any logic here. Just renamed functions to snake_case and moved them out of get_property

src/Utils.jl Show resolved Hide resolved
@mrufsvold
Copy link
Contributor Author

Pushed a doc string and kicked all the tests off again accidentally. Either way, ready for review!

@Kyjor
Copy link
Owner

Kyjor commented Jan 26, 2024

This is awesome, thank you! Give me an hour or two and I can fully review it and run some manual tests that aren't covered (yet) by automation

@Kyjor Kyjor merged commit fedc0ca into Kyjor:main Jan 26, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants