Refactor/deanonymize-get-prop-funcs #57
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't want to break the api, so I created a simple get_property function that looks up the correct function and then returns an anonymous function with "this" inserted in the first position.
I commented out a warning log about deprecation because basically every function call in the code base hits that warning at the moment. But once everything is moved to using direct function calls, we can turn on the warning to track down the last of them.
To be clear: I didn't change any logic here. Just renamed functions to snake_case and moved them out of
get_property