From ef8757785a1b7ca8f24122669dcbe17f4748e4e9 Mon Sep 17 00:00:00 2001 From: Tanishq S Date: Thu, 18 Dec 2025 12:45:26 +0530 Subject: [PATCH 1/3] test: add unit tests for task_repository --- backend/tests/test_task_repository.py | 32 +++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 backend/tests/test_task_repository.py diff --git a/backend/tests/test_task_repository.py b/backend/tests/test_task_repository.py new file mode 100644 index 0000000000..c305894d65 --- /dev/null +++ b/backend/tests/test_task_repository.py @@ -0,0 +1,32 @@ + +import pytest +from oasst_backend.task_repository import validate_frontend_message_id +from oasst_shared.exceptions.oasst_api_error import OasstError, OasstErrorCode + +def test_validate_frontend_message_id_valid(): + """Test that a valid string ID passes validation.""" + validate_frontend_message_id("valid-id-123") + +def test_validate_frontend_message_id_empty(): + """Test that an empty string raises an error.""" + with pytest.raises(OasstError) as excinfo: + validate_frontend_message_id("") + + assert excinfo.value.error_code == OasstErrorCode.INVALID_FRONTEND_MESSAGE_ID + assert "message_id must not be empty" in str(excinfo.value) + +def test_validate_frontend_message_id_none(): + """Test that None raises an error.""" + with pytest.raises(OasstError) as excinfo: + validate_frontend_message_id(None) + + assert excinfo.value.error_code == OasstErrorCode.INVALID_FRONTEND_MESSAGE_ID + assert "message_id must be string" in str(excinfo.value) + +def test_validate_frontend_message_id_wrong_type(): + """Test that a non-string type raises an error.""" + with pytest.raises(OasstError) as excinfo: + validate_frontend_message_id(12345) + + assert excinfo.value.error_code == OasstErrorCode.INVALID_FRONTEND_MESSAGE_ID + assert "message_id must be string" in str(excinfo.value) From bdf3df74c197ee786510ea6bfbcd8fe01e9ebb81 Mon Sep 17 00:00:00 2001 From: Tanishq S Date: Thu, 18 Dec 2025 13:11:39 +0530 Subject: [PATCH 2/3] style: fix pre-commit issues --- backend/tests/test_task_repository.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/backend/tests/test_task_repository.py b/backend/tests/test_task_repository.py index c305894d65..7af923014d 100644 --- a/backend/tests/test_task_repository.py +++ b/backend/tests/test_task_repository.py @@ -3,6 +3,7 @@ from oasst_backend.task_repository import validate_frontend_message_id from oasst_shared.exceptions.oasst_api_error import OasstError, OasstErrorCode + def test_validate_frontend_message_id_valid(): """Test that a valid string ID passes validation.""" validate_frontend_message_id("valid-id-123") @@ -11,7 +12,7 @@ def test_validate_frontend_message_id_empty(): """Test that an empty string raises an error.""" with pytest.raises(OasstError) as excinfo: validate_frontend_message_id("") - + assert excinfo.value.error_code == OasstErrorCode.INVALID_FRONTEND_MESSAGE_ID assert "message_id must not be empty" in str(excinfo.value) @@ -19,7 +20,7 @@ def test_validate_frontend_message_id_none(): """Test that None raises an error.""" with pytest.raises(OasstError) as excinfo: validate_frontend_message_id(None) - + assert excinfo.value.error_code == OasstErrorCode.INVALID_FRONTEND_MESSAGE_ID assert "message_id must be string" in str(excinfo.value) @@ -27,6 +28,6 @@ def test_validate_frontend_message_id_wrong_type(): """Test that a non-string type raises an error.""" with pytest.raises(OasstError) as excinfo: validate_frontend_message_id(12345) - + assert excinfo.value.error_code == OasstErrorCode.INVALID_FRONTEND_MESSAGE_ID assert "message_id must be string" in str(excinfo.value) From 58a18166e6e8b7ae3f171620f7158a233562dc48 Mon Sep 17 00:00:00 2001 From: Tanishq S Date: Thu, 18 Dec 2025 13:18:30 +0530 Subject: [PATCH 3/3] style: apply black formatting --- backend/tests/test_task_repository.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/backend/tests/test_task_repository.py b/backend/tests/test_task_repository.py index 7af923014d..101e2e0a67 100644 --- a/backend/tests/test_task_repository.py +++ b/backend/tests/test_task_repository.py @@ -1,4 +1,3 @@ - import pytest from oasst_backend.task_repository import validate_frontend_message_id from oasst_shared.exceptions.oasst_api_error import OasstError, OasstErrorCode @@ -8,6 +7,7 @@ def test_validate_frontend_message_id_valid(): """Test that a valid string ID passes validation.""" validate_frontend_message_id("valid-id-123") + def test_validate_frontend_message_id_empty(): """Test that an empty string raises an error.""" with pytest.raises(OasstError) as excinfo: @@ -16,6 +16,7 @@ def test_validate_frontend_message_id_empty(): assert excinfo.value.error_code == OasstErrorCode.INVALID_FRONTEND_MESSAGE_ID assert "message_id must not be empty" in str(excinfo.value) + def test_validate_frontend_message_id_none(): """Test that None raises an error.""" with pytest.raises(OasstError) as excinfo: @@ -24,6 +25,7 @@ def test_validate_frontend_message_id_none(): assert excinfo.value.error_code == OasstErrorCode.INVALID_FRONTEND_MESSAGE_ID assert "message_id must be string" in str(excinfo.value) + def test_validate_frontend_message_id_wrong_type(): """Test that a non-string type raises an error.""" with pytest.raises(OasstError) as excinfo: