Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iterator optimisation #126

Open
LDeakin opened this issue Jan 11, 2025 · 0 comments
Open

Iterator optimisation #126

LDeakin opened this issue Jan 11, 2025 · 0 comments
Labels
help wanted Extra attention is needed performance Performance related

Comments

@LDeakin
Copy link
Owner

LDeakin commented Jan 11, 2025

zarrs::array_subset::iterators have measurable overhead, probably mostly from allocation.

  • Could lending iterators be used instead to avoid repeated allocations?
    • rayon support?
  • Alternatively, just use smallvec or something? I did try this early on in zarrs development, but there wasn't a measurable performance difference and made the API less friendly. zarrs is more optimised now though.
@LDeakin LDeakin added help wanted Extra attention is needed performance Performance related labels Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed performance Performance related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LDeakin