Support for certain bootlag games with malformed headers, fixes #585

LIJI32 · LIJI32 · commit 8d063391a474 · 2024-01-13T18:06:22.000+02:00
diff --git a/Core/mbc.c b/Core/mbc.c
@@ -195,6 +195,14 @@ void GB_configure_cart(GB_gameboy_t *gb)
             GB_log(gb, "Cartridge type %02x is not yet supported.\n", gb->rom[0x147]);
         }
     }
+    
+    if (!gb->cartridge_type->has_ram &&
+        gb->cartridge_type->mbc_type != GB_NO_MBC &&
+        gb->cartridge_type->mbc_type != GB_TPP1 &&
+        gb->rom[0x149]) {
+        GB_log(gb, "ROM header reports no RAM, but also reports a non-zero RAM size. Assuming cartridge has RAM.\n");
+        gb->cartridge_type++;
+    }
         
     size_t old_mbc_ram_size = gb->mbc_ram_size;
     gb->mbc_ram_size = 0;

Original file line number	Diff line number	Diff line change
`@@ -195,6 +195,14 @@ void GB_configure_cart(GB_gameboy_t *gb)`
`195`	`195`	`GB_log(gb, "Cartridge type %02x is not yet supported.\n", gb->rom[0x147]);`
`196`	`196`	`}`
`197`	`197`	`}`
	`198`	`+`
	`199`	`+ if (!gb->cartridge_type->has_ram &&`
	`200`	`+ gb->cartridge_type->mbc_type != GB_NO_MBC &&`
	`201`	`+ gb->cartridge_type->mbc_type != GB_TPP1 &&`
	`202`	`+ gb->rom[0x149]) {`
	`203`	`+ GB_log(gb, "ROM header reports no RAM, but also reports a non-zero RAM size. Assuming cartridge has RAM.\n");`
	`204`	`+ gb->cartridge_type++;`
	`205`	`+ }`
`198`	`206`
`199`	`207`	`size_t old_mbc_ram_size = gb->mbc_ram_size;`
`200`	`208`	`gb->mbc_ram_size = 0;`