Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finished initial work with api #1

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Finished initial work with api #1

merged 3 commits into from
Dec 20, 2023

Conversation

LLkaia
Copy link
Owner

@LLkaia LLkaia commented Dec 15, 2023

  • added models for article
  • added functions to work with MongoDB
  • added routs for search and concrete article
  • added scripts for scraping

AVK1206
AVK1206 reviewed Dec 16, 2023
View reviewed changes
Copy link
Collaborator

@AVK1206 AVK1206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general please add documentation to ur files. Follow PEP 8 and PEP 257.
README file is important to understand what's going on in ur project but ur README file is empty so please update README.

requirements.txt Outdated Show resolved Hide resolved
server/database.py Outdated Show resolved Hide resolved
server/models/search_result.py Outdated Show resolved Hide resolved
server/app.py Show resolved Hide resolved
server/scraper.py Show resolved Hide resolved
AVK1206
AVK1206 reviewed Dec 16, 2023
View reviewed changes
Copy link
Collaborator

@AVK1206 AVK1206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If u don't need empty init files would be better to delete them.

@LLkaia
Copy link
Owner Author

LLkaia commented Dec 16, 2023

If u don't need empty init files would be better to delete them.

FastAPI's docs recommend to use them (i agree that they are not necessary in python now)

@LLkaia LLkaia requested a review from AVK1206 December 16, 2023 13:22
@LLkaia LLkaia merged commit 6135d55 into main Dec 20, 2023
2 checks passed
@LLkaia LLkaia deleted the news-searcher branch January 3, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VovaD199 VovaD199 VovaD199 approved these changes

@mehalyna mehalyna Awaiting requested review from mehalyna

@Vladyslava-K Vladyslava-K Awaiting requested review from Vladyslava-K

@AVK1206 AVK1206 Awaiting requested review from AVK1206

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LLkaia @VovaD199 @AVK1206