Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC]: Allow for stategy listener priority to be configurable #174

Open
visto9259 opened this issue Jan 28, 2025 · 0 comments
Open

[RFC]: Allow for stategy listener priority to be configurable #174

visto9259 opened this issue Jan 28, 2025 · 0 comments
Milestone

Comments

@visto9259
Copy link
Member

RFC

Q A
Proposed Version(s) 4.2.x
BC Break? No

Goal

Priorities of strategy listeners are currently hard-coded.
Allow for priorities to be configurable with default values being set to the current hard-coded values.

Background

#172 provided a quick patch to fix priority issues for the UnAuthorizedStrategy that defaults to 1 which is the same priority as MVC's listeners to the MvcEvent::EVENT_DISPATCH_ERROR.

Considerations

  • Modifying priority must be done after thoughtful consideration and a good understanding of how the MvcEven is handled in the application.
  • Documentation is needed to explain the impact

Proposal(s)

  • Add a prority option to listener configurations in lmc_rbac config for strategy listener
  • Update documentation to explain how to change priority and potential impacts

Appendix

@visto9259 visto9259 added enhancement New feature or request feature request and removed enhancement New feature or request labels Jan 28, 2025
@visto9259 visto9259 moved this from 🆕 New to 📋 To Do in LmcRbacMvc Development Jan 28, 2025
@visto9259 visto9259 added this to the 4.2.0 milestone Jan 28, 2025
@visto9259 visto9259 changed the title [RFC]: Allow for statgey listener priority to be configurable [RFC]: Allow for stategy listener priority to be configurable Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 To Do
Development

No branches or pull requests

1 participant