-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Description
From sunpy/sunkit-instruments#5
This issue proposes what the IRIS submodule of this package should look like.
- This subpackage should replace the IRIS-specific functionality in
sunrasterwith the exception of the spectrograph reader functions.- For raster data, it should NOT provide raster classes, but instead provide functions that act on
sunrasterobjects.- The
irissubmodule should provide the following classes:
IRISMapCubeIRISMapCubeSequence(Consider renaming toIRISMapSequence?)ObsIdirissubmodule should NOT provide the following classes and functions:
IRISSpectrographIRISSpectrogramCubeSequenceIRISSpectrogramCubecalculate_exposure_time_correctionanduncalculate_exposure_time_correction. (These are now handled bysunraster.)_convert_iris_sequence(Not used anywhere. Double check this.)- The following methods from
IRISMapCube/SequenceandIRISSpectrogramCube/Sequenceclasses should be provided as functions that takeRasterandRasterSequenceobjects fromsunraster:
IRISSpectrogramCube.convert_to()andIRISSpectrogramSequence.convert_to()->convert_iris_spectrogram_to()(or better named function).
- This function should accept an
IRISSpectrogramCubeorIRISSpectrogramSequence, convert the data, and return a new instance of the input class.- This will require private versions of the function of the Cube and Sequence cases.
IRISMapCube.convert_to()andIRISMapSequence.convert_to()->convert_iris_map_to()(or better named function).
- This function should accept an
IRISMapCubeorIRISMapSequence, convert the data, and return a new instance of the input class.- This will require private versions of the function of the Cube and Sequence cases.
irissubpackage should contain the following modules:
obsid.py
ObsIdspectrograph.py
convert_iris_spectrogramcalculate_orbital_wavelength_variation- FUV and NUV DN unit equivalencies
sji.py
convert_iris_mapapply_dust_maskcalculate_dust_maskread_iris_sji_level2_fits- SJI DN unit equivalency
utils.py(for utils that are independent of whether data is from SJI or SG.)
get_iris_responsefit_iris_xputget_detector_typeconvert_between_DN_and_photonsconvert_or_undo_photons_per_sec_to_radiancecalculate_uncertainty(Take a sunraster or IRISMap object and calculate the uncertainty based on the data and some detector properties. Attach to the input object'suncertaintyattribute.Some tools have not been mentioned here but should also be included in the most logical place if above functions depend on them. Any functions not used anywhere should be considered for deletion.
When this submodule or features within it can be deprecated once the instrument-team-backed
IRISpypackage is released.
Metadata
Metadata
Assignees
Labels
No labels