Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sesión 11 #230

Merged
merged 22 commits into from
Mar 31, 2022
Merged

Sesión 11 #230

merged 22 commits into from
Mar 31, 2022

Conversation

icarito
Copy link
Collaborator

@icarito icarito commented Mar 28, 2022

Kickoff para hacer merge a los ejercicios de la sesión 11

@icarito icarito added this to the Sesión 11 milestone Mar 28, 2022
@icarito icarito mentioned this pull request Mar 28, 2022
@icarito icarito changed the title Kickoff session 11 branch Sesión 11 Mar 28, 2022
@icarito icarito self-assigned this Mar 28, 2022
Copy link
Contributor

@santiaguf santiaguf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@icarito
Copy link
Collaborator Author

icarito commented Mar 31, 2022

@reloadercf creo que hubo por ahí un merge, lo revertí -
@santiaguf gracias por el review!
y gracias a todos los que contribuyeron a esta sesión!

@icarito icarito closed this Mar 31, 2022
@icarito icarito reopened this Mar 31, 2022
@icarito icarito merged commit 45d7c24 into main Mar 31, 2022
@icarito icarito deleted the session_11 branch March 31, 2022 03:42
"folders/match-regex": [2, "^([a-z][a-z0-9]*)(-[a-z0-9]+)*$", "/exercises/"]
"folders/match-regex": [2, "^([a-z][a-z0-9]*)(-[a-z0-9]+)*$", "/exercises/"],
"no-else-return": "off",
"no-lonely-if": "off"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sería bueno conversar sobre estas reglas de linter...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lo que quiero decir es que sería bueno seguir todas o documentar porqué se desactivó alguna.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
9 participants